Repository navigation
chore(sample): Remove unused Detox setup from the React Native sample - #7072
Merged
Merged
Conversation
The sample E2E tests run on Maestro. Nothing runs Detox: .detoxrc.js points at an e2e-detox folder that doesn't exist, and CI deletes the androidTest APK before the Maestro tests. Detox still broke RN bumps because its Android code references removed React Native classes (RN 0.84, and TimingModule in RN 0.89). - Remove .detoxrc.js, DetoxTest.java and the detox devDependency - Remove the Detox Gradle dependency, Maven repo and ProGuard rules - Stop building and archiving app-androidTest.apk Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
alwx
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Removes the leftover Detox setup from
samples/react-native. The sample E2E tests run on Maestro, and nothing runs Detox:.detoxrc.jspoints ate2e-detox/jest.config.*.js, and that folder doesn't exist.package.jsonscript callsdetox.app-androidTest.apk(it only containsDetoxTest.java) and archives it with the app, then the Maestro job deletes it.Changes:
.detoxrc.jsandandroid/app/src/androidTest/.../DetoxTest.java.detoxdevDependency and itsajvresolution in the rootpackage.json; regenerateyarn.lock.android/app/build.gradle: removecom.wix:detox, the Detox ProGuard file,testProguardFiles,testBuildTypeandtestInstrumentationRunner.android/build.gradle: remove the Detox Maven repo.proguard-rules.pro: remove the two Detox workarounds (-keep class kotlin.**and-dontwarn ...NotThreadSafeBridgeIdleDebugListener).scripts/build-android.sh: stop buildingapp:assembleAndroidTest.sample-application.yml: stop archivingapp-androidTest.apkand drop the step that deleted it.💡 Motivation and Context
Detox breaks React Native bumps without testing anything. Its Android code references React Native classes that get removed: RN 0.84 needed a
-dontwarnworkaround, and RN 0.89 removesTimingModule, which fails R8 on the test APK in #7071 (Missing class com.facebook.react.modules.core.TimingModule). Even the latest Detox (20.51.4) still references it. Removing Detox unblocks #7071 without another workaround and saves building the test APK on CI.💚 How did you test it?
On
main(RN 0.88.1), New Architecture:scripts/build-android.shwithCONFIG=release(R8 enabled):BUILD SUCCESSFUL.-keep class kotlin.**rule is safe.The Maestro sample E2E jobs run on CI with the
ready-to-mergelabel.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Rebase #7071 once this merges.
🤖 Generated with Claude Code