Skip to content

chore(sample): Remove unused Detox setup from the React Native sample - #7072

Merged
antonis merged 1 commit into
mainfrom
antonis/remove-detox-sample
Nov 19, 2026
Merged

antonis merged 1 commit into
mainfrom
antonis/remove-detox-sample

Conversation

@antonis

@antonis antonis commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Removes the leftover Detox setup from samples/react-native. The sample E2E tests run on Maestro, and nothing runs Detox:

  • .detoxrc.js points at e2e-detox/jest.config.*.js, and that folder doesn't exist.
  • No workflow, script or package.json script calls detox.
  • CI builds app-androidTest.apk (it only contains DetoxTest.java) and archives it with the app, then the Maestro job deletes it.

Changes:

  • Delete .detoxrc.js and android/app/src/androidTest/.../DetoxTest.java.
  • Remove the detox devDependency and its ajv resolution in the root package.json; regenerate yarn.lock.
  • android/app/build.gradle: remove com.wix:detox, the Detox ProGuard file, testProguardFiles, testBuildType and testInstrumentationRunner.
  • android/build.gradle: remove the Detox Maven repo.
  • proguard-rules.pro: remove the two Detox workarounds (-keep class kotlin.** and -dontwarn ...NotThreadSafeBridgeIdleDebugListener).
  • scripts/build-android.sh: stop building app:assembleAndroidTest.
  • sample-application.yml: stop archiving app-androidTest.apk and drop the step that deleted it.

💡 Motivation and Context

Detox breaks React Native bumps without testing anything. Its Android code references React Native classes that get removed: RN 0.84 needed a -dontwarn workaround, and RN 0.89 removes TimingModule, which fails R8 on the test APK in #7071 (Missing class com.facebook.react.modules.core.TimingModule). Even the latest Detox (20.51.4) still references it. Removing Detox unblocks #7071 without another workaround and saves building the test APK on CI.

💚 How did you test it?

On main (RN 0.88.1), New Architecture:

  • Ran scripts/build-android.sh with CONFIG=release (R8 enabled): BUILD SUCCESSFUL.
  • Installed the release APK on an Android emulator and launched it: the app starts, the Sentry SDK initializes, no crash. This checks that dropping the broad -keep class kotlin.** rule is safe.

The Maestro sample E2E jobs run on CI with the ready-to-merge label.

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

Rebase #7071 once this merges.

🤖 Generated with Claude Code

The sample E2E tests run on Maestro. Nothing runs Detox: .detoxrc.js
points at an e2e-detox folder that doesn't exist, and CI deletes the
androidTest APK before the Maestro tests. Detox still broke RN bumps
because its Android code references removed React Native classes
(RN 0.84, and TimingModule in RN 0.89).

- Remove .detoxrc.js, DetoxTest.java and the detox devDependency
- Remove the Detox Gradle dependency, Maven repo and ProGuard rules
- Stop building and archiving app-androidTest.apk

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • chore(sample): Remove unused Detox setup from the React Native sample by antonis and claude in #7072
  • ci(ios): Build TestFlight sample with Xcode 27 by philprime with sentry-junior in #7065
  • perf(android): Create SDK view managers on demand by alwx in #7049
  • fix(core): Remove web Replay and Feedback from native bundles by default by huextrat, claude and antonis in #7062
  • fix(core): Define UnsafeObject locally instead of deep importing it by alwx in #7061
  • chore(deps): update Android SDK to v8.65.0 by github-actions in #7058

🤖 This preview updates automatically when you update the PR.

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 19, 2026
@antonis
antonis marked this pull request as ready for review November 19, 2026 13:05
@antonis
antonis merged commit 7e0cd07 into main Nov 19, 2026
105 of 125 checks passed
@antonis
antonis deleted the antonis/remove-detox-sample branch November 19, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants