Repository navigation
Replace string matching workarounds with string predicates - #23177
aschackmull wants to merge 3 commits into
Conversation
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
| @@ -65,7 +65,7 @@ | |||
| exists(IntegerLiteral lit | lit = e | | |||
| not exists(lit.getValue()) and | |||
| /* Not a set of flags or round number */ | |||
| not lit.toString().matches("%00%") | |||
| not lit.toString().contains("00") | |||
| @@ -13,7 +13,7 @@ | |||
| */ | |||
| predicate relevantNode(AstNode node) { | |||
| // Match an ancestor node by location so its whole subtree is shown. | |||
| node.getParent*().getLocation().toString().matches("%test.swift@13:%") | |||
| node.getParent*().getLocation().toString().contains("test.swift@13:") | |||
| @@ -13,7 +13,7 @@ | |||
| */ | |||
| predicate relevantNode(AstNode node) { | |||
| // Match an ancestor node by location so its whole subtree is shown. | |||
| node.getParent*().getLocation().toString().matches("%test.swift@227:%") | |||
| node.getParent*().getLocation().toString().contains("test.swift@227:") | |||
| @@ -13,7 +13,7 @@ | |||
| */ | |||
| predicate relevantNode(AstNode node) { | |||
| // Match an ancestor node by location so its whole subtree is shown. | |||
| node.getParent*().getLocation().toString().matches("%test.swift@13:%") | |||
| node.getParent*().getLocation().toString().contains("test.swift@13:") | |||
| (result.startsWith("ES") implies not f.getName().toUpperCase().contains("AES")) and | ||
| // RSA false positives | ||
| (result.matches("RSA") implies not f.getName().toUpperCase().matches("%UNIVERSAL%")) and | ||
| (result.matches("RSA") implies not f.getName().toUpperCase().contains("UNIVERSAL")) and |
| (result.matches("ARIA") implies not f.getName().toUpperCase().contains("VARIANT")) and | ||
| // CTR false positives | ||
| (result.matches("CTR") implies not f.getName().toUpperCase().matches("%CTRL%")) and | ||
| (result.matches("CTR") implies not f.getName().toUpperCase().contains("CTRL")) and |
| ) and | ||
| // ARIA specific false positives | ||
| (result.matches("ARIA") implies not f.getName().toUpperCase().matches("%VARIANT%")) and | ||
| (result.matches("ARIA") implies not f.getName().toUpperCase().contains("VARIANT")) and |
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
|
I've validated the bulk commit by checking that the diff matched a sequence of simple regexes. |
There was a problem hiding this comment.
🟡 Changes recommended
The builtin registry lacks startsWith, contains, and endsWith, leaving rewritten calls unresolved and preventing analyses using Call.getTarget() from recognizing them.
1 open issue
What changed in this PR
This PR simplifies string checks across CodeQL libraries, queries, tests, and examples by using dedicated string predicates instead of pattern-matching workarounds.
Changes:
- Replaces simple prefix, substring, and suffix checks with
startsWith,contains, andendsWith. - Replaces one inverse-concatenation prefix check and updates several commented examples.
- Retains patterns with additional matching semantics.
QL tests were not run because the CodeQL CLI was unavailable.
| File | Description |
|---|---|
| unified/ql/src/queries/unusedentities/UnusedVariable.ql | Simplifies underscore-prefix exclusion. |
| unified/ql/lib/codeql/unified/internal/typeinference/TypeInference.qll | Simplifies debug-file selection. |
| unified/ql/lib/codeql/unified/internal/mad/LegacyMaD.qll | Simplifies property-name check. |
| unified/ql/lib/codeql/unified/internal/dev/debugStaticNameBindingGraph.ql | Simplifies debug-location matching. |
| unified/ql/lib/codeql/unified/internal/dev/debugLocalNameBindingGraph.ql | Simplifies debug-location matching. |
| unified/ql/lib/codeql/unified/internal/dev/debugDataFlowGraph.ql | Simplifies debug-location matching. |
| swift/ql/test/TestUtils.qll | Simplifies test-path filtering. |
| swift/ql/test/library-tests/regex/regex.ql | Simplifies space detection. |
| swift/ql/test/library-tests/elements/decl/function/function.ql | Simplifies initializer exclusion. |
| swift/ql/test/library-tests/dataflow/flowsources/FlowSourcesInline.ql | Simplifies sink-name matching. |
| swift/ql/test/library-tests/dataflow/dataflow/FlowConfig.qll | Simplifies source-name matching. |
| swift/ql/test/library-tests/controlflow/graph/Cfg.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/types/Types.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/types/ThrowingAndAsync.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/types/StructDecls.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/types/ClassDecls.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/statements/YieldStmts.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/statements/Labels.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/statements/LabeledStmts.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/statements/LabeledConditionalStmts.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/statements/ConditionElements.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/patterns/all.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/expressions/semantics.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/expressions/all.ql | Simplifies test-path filtering. |
| swift/ql/test/extractor-tests/declarations/all.ql | Simplifies test-path filtering. |
| swift/ql/src/diagnostics/internal/UnresolvedAstNodes.ql | Simplifies unresolved-class matching. |
| swift/ql/lib/utils/test/InlineFlowTest.qll | Simplifies sink-name matching. |
| swift/ql/lib/codeql/swift/StringFormat.qll | Simplifies format-initializer matching. |
| swift/ql/lib/codeql/swift/regex/Regex.qll | Simplifies replacement-method matching. |
| swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Dictionary.qll | Simplifies dictionary-type matching. |
| swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Array.qll | Simplifies array-type matching. |
| swift/ql/lib/codeql/swift/elements/internal/FileImpl.qll | Simplifies absolute-path exclusion. |
| swift/ql/integration-tests/posix/deduplication/BuiltinTypes.ql | Simplifies builtin-type exclusions. |
| swift/ql/integration-tests/linux/RegexLiteralExpr/RegexLiteralExpr.ql | Simplifies fixture-file selection. |
| swift/ql/consistency-queries/UnresolvedAstNodes.ql | Simplifies unresolved-class matching. |
| shared/yaml/codeql/yaml/Yaml.qll | Simplifies path classification. |
| shared/util/codeql/util/FilePath.qll | Simplifies root-path detection. |
| shared/regex/codeql/regex/OverlyLargeRangeQuery.qll | Simplifies hyphen detection. |
| shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll | Simplifies sink-label detection. |
| rust/ql/test/TestUtils.qll | Simplifies comment-marker exclusion. |
| rust/ql/lib/utils/test/PathResolutionInlineExpectationsTest.qll | Simplifies comment-marker exclusion. |
| rust/ql/lib/utils/test/InlineFlowTest.qll | Simplifies space detection. |
| rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll | Simplifies debug-file selection. |
| rust/ql/lib/codeql/rust/internal/PathResolution.qll | Simplifies debug-file selection. |
| rust/ql/lib/codeql/rust/frameworks/stdlib/Builtins.qll | Simplifies tuple-type matching. |
| rust/ql/lib/codeql/rust/frameworks/rustcrypto/RustCrypto.qll | Simplifies triple-DES recognition. |
| rust/ql/integration-tests/subst/file.ql | Simplifies path exclusion. |
| rust/ql/examples/snippets/simple_constant_password.ql | Simplifies password-name matching. |
| ruby/ql/src/queries/summary/LinesOfUserCode.ql | Simplifies vendor-path exclusion. |
| ruby/ql/src/queries/modeling/internal/Util.qll | Simplifies test-path exclusion. |
| ruby/ql/lib/codeql/ruby/security/SensitiveActions.qll | Simplifies action-suffix detection. |
| ruby/ql/lib/codeql/ruby/security/internal/CleartextSources.qll | Simplifies mutation-method exclusion. |
| ruby/ql/lib/codeql/ruby/frameworks/Sinatra.qll | Simplifies template-path matching. |
| ruby/ql/lib/codeql/ruby/frameworks/Rails.qll | Simplifies test-configuration matching. |
| ruby/ql/lib/codeql/ruby/frameworks/GraphQL.qll | Simplifies load-method matching. |
| ruby/ql/lib/codeql/ruby/frameworks/actiondispatch/internal/Routing.qll | Simplifies plural-suffix check. |
| ruby/ql/lib/codeql/ruby/frameworks/ActionController.qll | Simplifies layout-path matching. |
| ruby/ql/lib/codeql/ruby/dataflow/internal/FlowSummaryImpl.qll | Simplifies argument-suffix check. |
| ruby/ql/lib/codeql/ruby/ApiGraphs.qll | Simplifies namespace-separator detection. |
| ql/ql/src/queries/style/ToStringInQueryLogic.ql | Simplifies query-extension check. |
| ql/ql/src/queries/style/NonDocBlock.ql | Simplifies documentation-prefix check. |
| ql/ql/src/queries/style/DataFlowConfigModuleNaming.ql | Simplifies configuration-suffix check. |
| ql/ql/src/queries/style/ConsistentAlertMessage.ql | Simplifies experimental-path exclusion. |
| ql/ql/src/queries/bugs/PathProblemQuery.ql | Simplifies test-path exclusion. |
| ql/ql/src/codeql_ql/bugs/PathProblemQueryQuery.qll | Simplifies query-kind detection. |
| ql/ql/src/codeql_ql/ast/Ast.qll | Simplifies package-prefix check. |
| python/tools/recorded-call-graph-metrics/ql/lib/RecordedCalls.qll | Simplifies qualified-name checks. |
| python/ql/test/library-tests/PointsTo/new/PointsToMissing.ql | Simplifies check-marker detection. |
| python/ql/test/library-tests/PointsTo/new/Consistency.ql | Simplifies class-prefix check. |
| python/ql/test/library-tests/PointsTo/general/interesting.qll | Simplifies fixture-path matching. |
| python/ql/test/library-tests/PointsTo/functions/Calls.ql | Simplifies fixture-name matching. |
| python/ql/test/extractor-tests/flags/Flags.ql | Simplifies option-prefix checks. |
| python/ql/src/Variables/UnusedParameter.ql | Simplifies abstract-decorator matching. |
| python/ql/src/Variables/Definition.qll | Simplifies unused-name checks. |
| python/ql/src/Statements/UnusedExceptionObject.ql | Simplifies exception-name matching. |
| python/ql/src/Statements/RedundantAssignment.ql | Simplifies comment-marker detection. |
| python/ql/src/Security/CWE-352/CSRFProtectionDisabled.ql | Simplifies test-path exclusion. |
| python/ql/src/meta/debug/SimpleClassDebug.ql | Updates commented path example. |
| python/ql/src/Lexical/ToDoComment.ql | Simplifies TODO detection. |
| python/ql/src/Imports/UnusedImport.ql | Simplifies type-comment detection. |
| python/ql/src/Functions/IncorrectRaiseInSpecialMethod.ql | Simplifies abstract-decorator matching. |
| python/ql/src/external/Thrift.qll | Simplifies type-suffix check. |
| python/ql/src/experimental/semmle/python/libraries/PythonJose.qll | Simplifies verification-option matching. |
| python/ql/src/experimental/semmle/python/libraries/PyJWT.qll | Simplifies verification-option matching. |
| python/ql/src/experimental/cryptography/example_alerts/WeakBlockMode.ql | Simplifies library-path matching. |
| python/ql/src/Classes/ClassAttributes.qll | Simplifies abstract-class matching. |
| python/ql/lib/utils/test/dataflow/MaximalFlowTest.qll | Simplifies sink-name exclusion. |
| python/ql/lib/semmle/python/types/ModuleObject.qll | Simplifies package-separator detection. |
| python/ql/lib/semmle/python/security/dataflow/TarSlipCustomizations.qll | Simplifies path-name matching. |
| python/ql/lib/semmle/python/objects/TObject.qll | Simplifies typing-module matching. |
| python/ql/lib/semmle/python/Import.qll | Simplifies package-separator detection. |
| python/ql/lib/semmle/python/frameworks/ServerLess.qll | Simplifies runtime-prefix check. |
| python/ql/lib/semmle/python/frameworks/Peewee.qll | Updates commented database checks. |
| python/ql/lib/semmle/python/frameworks/internal/SubclassFinder.qll | Simplifies test-directory detection. |
| python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll | Simplifies SymPy-path exclusion. |
| python/ql/lib/semmle/python/Class.qll | Simplifies mixin-name detection. |
| python/ql/lib/modeling/Util.qll | Simplifies test-path exclusion. |
| python/ql/lib/experimental/cryptography/modules/stdlib/HashlibModule.qll | Simplifies private-name exclusion. |
| python/ql/examples/snippets/raw_string.ql | Simplifies raw-prefix detection. |
| javascript/ql/test/tutorials/Validating RAML-based APIs/RAML.qll | Simplifies resource-prefix check. |
| javascript/ql/test/tutorials/Validating RAML-based APIs/query4.ql | Simplifies resource-prefix check. |
| javascript/ql/test/tutorials/Validating RAML-based APIs/query3.ql | Simplifies resource-prefix check. |
| javascript/ql/test/tutorials/Validating RAML-based APIs/query2.ql | Simplifies resource-prefix check. |
| javascript/ql/test/library-tests/TypeScript/Namespaces/CheckGlobals.ql | Simplifies global-prefix checks. |
| javascript/ql/test/library-tests/StringConcatenation/ContainsTwo.ql | Simplifies substring detection. |
| javascript/ql/test/library-tests/StringConcatenation/ClassContainsTwo.ql | Simplifies substring detection. |
| javascript/ql/test/library-tests/RegExp/MissingUnicodeFlag/MissingUnicodeFlag.ql | Simplifies Unicode-flag check. |
| javascript/ql/test/library-tests/RangeAnalysis/DeadBranch.ql | Simplifies assertion-marker checks. |
| javascript/ql/test/library-tests/frameworks/Spife/tests.ql | Simplifies expectation-marker checks. |
| javascript/ql/test/library-tests/frameworks/Shelljs/ShellJS.ql | Simplifies variable-prefix check. |
| javascript/ql/test/library-tests/frameworks/Restify2/tests.ql | Simplifies expectation-marker checks. |
| javascript/ql/test/library-tests/dependencies/DependencyCustomizations.qll | Simplifies framework-marker detection. |
| javascript/ql/test/library-tests/Classes/tests.ql | Simplifies private-identifier detection. |
| javascript/ql/test/experimental/TypeOrm/tests.ql | Simplifies expectation-marker exclusion. |
| javascript/ql/src/Statements/ImplicitReturn.ql | Simplifies throw-name detection. |
| javascript/ql/src/Security/CWE-730/ServerCrash.ql | Simplifies synchronous-method exclusion. |
| javascript/ql/src/Security/CWE-384/SessionFixation.ql | Simplifies login-path matching. |
| javascript/ql/src/Security/CWE-020/IncompleteUrlSchemeCheck.ql | Simplifies trim-method matching. |
| javascript/ql/src/NodeJS/UnusedDependency.ql | Simplifies leading-dot detection. |
| javascript/ql/src/NodeJS/UnresolvableImport.ql | Simplifies loader-marker exclusion. |
| javascript/ql/src/Expressions/UnknownDirective.ql | Simplifies Babel-directive exclusion. |
| javascript/ql/src/Expressions/CompareIdenticalValues.ql | Simplifies NaN-comment detection. |
| javascript/ql/src/experimental/Security/CWE-444/InsecureHttpParser.ql | Simplifies parser-option detection. |
| javascript/ql/src/DOM/TargetBlank.ql | Simplifies href-name matching. |
| javascript/ql/src/Declarations/UnusedProperty.ql | Simplifies special-property exclusion. |
| javascript/ql/src/Declarations/UnusedParameter.qll | Simplifies unused-documentation detection. |
| javascript/ql/src/AngularJS/InsecureUrlWhitelist.ql | Simplifies wildcard detection. |
| javascript/ql/src/AngularJS/IncompatibleService.ql | Simplifies provider-suffix check. |
| javascript/ql/lib/utils/test/ConsistencyChecking.qll | Simplifies inconsistency-marker detection. |
| javascript/ql/lib/semmle/javascript/TSConfig.qll | Simplifies wildcard exclusion. |
| javascript/ql/lib/semmle/javascript/security/UselessUseOfCat.qll | Simplifies template-string checks. |
| javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomCustomizations.qll | Simplifies attribute-prefix checks. |
| javascript/ql/lib/semmle/javascript/security/dataflow/UrlConcatenation.qll | Simplifies trailing-slash detection. |
| javascript/ql/lib/semmle/javascript/security/dataflow/PrototypePollutionCustomizations.qll | Replaces inverse-concatenation prefix check. |
| javascript/ql/lib/semmle/javascript/security/dataflow/MissingRateLimiting.qll | Simplifies limiter-class matching. |
| javascript/ql/lib/semmle/javascript/security/dataflow/InsecureTemporaryFileCustomizations.qll | Simplifies temporary-path detection. |
| javascript/ql/lib/semmle/javascript/NodeModuleResolutionImpl.qll | Simplifies relative-export detection. |
| javascript/ql/lib/semmle/javascript/NodeJS.qll | Simplifies absolute-path detection. |
| javascript/ql/lib/semmle/javascript/Modules.qll | Simplifies relative-path detection. |
| javascript/ql/lib/semmle/javascript/linters/JSLint.qll | Simplifies directive-separator detection. |
| javascript/ql/lib/semmle/javascript/JsonSchema.qll | Simplifies schema-URL matching. |
| javascript/ql/lib/semmle/javascript/JSDoc.qll | Simplifies simple-name check. |
| javascript/ql/lib/semmle/javascript/HTML.qll | Simplifies absolute-path detection. |
| javascript/ql/lib/semmle/javascript/heuristics/AdditionalFrameworks.qll | Simplifies library-suffix checks. |
| javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll | Simplifies name-separator exclusion. |
| javascript/ql/lib/semmle/javascript/frameworks/UriLibraries.qll | Simplifies setter-name matching. |
| javascript/ql/lib/semmle/javascript/frameworks/SystemCommandExecutors.qll | Simplifies synchronous-name checks. |
| javascript/ql/lib/semmle/javascript/frameworks/Spife.qll | Simplifies validated-property matching. |
| javascript/ql/lib/semmle/javascript/frameworks/ShellJS.qll | Simplifies option-prefix detection. |
| javascript/ql/lib/semmle/javascript/frameworks/Markdown.qll | Simplifies sanitizer-plugin matching. |
| javascript/ql/lib/semmle/javascript/frameworks/Babel.qll | Simplifies configuration-name matching. |
| javascript/ql/lib/semmle/javascript/frameworks/AsyncPackage.qll | Simplifies Limit-suffix check. |
| javascript/ql/lib/semmle/javascript/frameworks/AngularJS/AngularJSExpressions.qll | Simplifies Angular-attribute detection. |
| javascript/ql/lib/semmle/javascript/filters/ClassifyFiles.qll | Simplifies test-filename detection. |
| javascript/ql/lib/semmle/javascript/Files.qll | Simplifies declaration-extension check. |
| javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll | Simplifies jQuery-marker detection. |
| javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll | Simplifies getter-name matching. |
| javascript/ql/lib/semmle/javascript/AST.qll | Simplifies declaration-file detection. |
| javascript/ql/integration-tests/subst/file.ql | Simplifies path exclusion. |
| javascript/ql/examples/queries/dataflow/DecodingAfterSanitization/DecodingAfterSanitizationGeneralized.ql | Simplifies decoder-name matching. |
| javascript/ql/examples/queries/dataflow/DecodingAfterSanitization/DecodingAfterSanitization.ql | Simplifies decoder-name matching. |
| java/ql/test/query-tests/security/CWE-730/ExpRedos/ReDoS.ql | Simplifies space detection. |
| java/ql/test/library-tests/wildcards-and-captured-types/test.ql | Simplifies type-text matching. |
| java/ql/test/library-tests/unknown-method-reference-lhs/Diags.ql | Simplifies diagnostic exclusion. |
| java/ql/test/library-tests/module-info-wrong-name/Diags.ql | Simplifies diagnostic exclusion. |
| java/ql/test/library-tests/errortype/Diags.ql | Simplifies diagnostic exclusion. |
| java/ql/test/library-tests/errortype-with-params/Diags.ql | Simplifies diagnostic exclusion. |
| java/ql/test/library-tests/dispatch/viableCallable.ql | Simplifies fixture-name matching. |
| java/ql/test-kotlin2/library-tests/type_equivalences/type_equivalences.ql | Simplifies method-prefix check. |
| java/ql/test-kotlin2/library-tests/parameter-defaults/flowTest.ql | Simplifies flow-marker checks. |
| java/ql/test-kotlin2/library-tests/parameter-defaults/erasure.ql | Simplifies default-method matching. |
| java/ql/test-kotlin2/library-tests/nested_types/types.ql | Simplifies type-name matching. |
| java/ql/test-kotlin2/library-tests/methods/diagnostics.ql | Simplifies diagnostic exclusion. |
| java/ql/test-kotlin2/library-tests/java-list-kotlin-user/test.ql | Simplifies class-prefix check. |
| java/ql/test-kotlin2/library-tests/instances/classes.ql | Simplifies class-prefix check. |
| java/ql/test-kotlin2/library-tests/enum/test.ql | Simplifies enum-prefix check. |
| java/ql/test-kotlin2/library-tests/compilation-units/cus.ql | Simplifies compilation-unit matching. |
| java/ql/test-kotlin2/library-tests/annotation-accessor-result-type/test.ql | Simplifies class-type matching. |
| java/ql/test-kotlin1/library-tests/type_equivalences/type_equivalences.ql | Simplifies method-prefix check. |
| java/ql/test-kotlin1/library-tests/parameter-defaults/flowTest.ql | Simplifies flow-marker checks. |
| java/ql/test-kotlin1/library-tests/parameter-defaults/erasure.ql | Simplifies default-method matching. |
| java/ql/test-kotlin1/library-tests/methods/diagnostics.ql | Simplifies diagnostic exclusion. |
| java/ql/test-kotlin1/library-tests/java-list-kotlin-user/test.ql | Simplifies class-prefix check. |
| java/ql/test-kotlin1/library-tests/instances/classes.ql | Simplifies class-prefix check. |
| java/ql/test-kotlin1/library-tests/compilation-units/cus.ql | Simplifies compilation-unit matching. |
| java/ql/test-kotlin1/library-tests/annotation-accessor-result-type/test.ql | Simplifies class-type matching. |
| java/ql/src/Violations of Best Practice/Dead Code/DeadRefTypes.ql | Simplifies framework-tag checks. |
| java/ql/src/Violations of Best Practice/Comments/TodoComments.ql | Simplifies TODO-marker detection. |
| java/ql/src/utils/modelconverter/ExtractSummaries.ql | Simplifies generated-model exclusion. |
| java/ql/src/utils/modelconverter/ExtractSources.ql | Simplifies generated-model exclusion. |
| java/ql/src/utils/modelconverter/ExtractSinks.ql | Simplifies generated-model exclusion. |
| java/ql/src/utils/modelconverter/ExtractNeutrals.ql | Simplifies generated-model exclusion. |
| java/ql/src/Security/CWE/CWE-338/JHipsterGeneratedPRNG.ql | Simplifies generator-name matching. |
| java/ql/src/Security/CWE/CWE-1104/MavenPomDependsOnBintray.ql | Simplifies repository-URL matching. |
| java/ql/src/Security/CWE/CWE-1004/SensitiveCookieNotHttpOnly.ql | Simplifies HttpOnly detection. |
| java/ql/src/Likely Bugs/Statements/InconsistentCallOnResult.ql | Simplifies method-prefix exclusions. |
| java/ql/src/Likely Bugs/Resource Leaks/CloseType.qll | Simplifies close-method matching. |
| java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql | Simplifies format-character checks. |
| java/ql/src/Likely Bugs/Frameworks/Swing/BadlyOverriddenAdapter.ql | Simplifies adapter-name matching. |
| java/ql/src/Likely Bugs/Concurrency/SynchSetUnsynchGet.ql | Simplifies setter-name matching. |
| java/ql/src/Likely Bugs/Concurrency/BusyWait.ql | Simplifies concurrent-package matching. |
| java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql | Simplifies assertion-name matching. |
| java/ql/src/Likely Bugs/Comparison/HashedButNoHash.ql | Simplifies hash-type matching. |
| java/ql/src/experimental/Security/CWE/CWE-759/HashWithoutSalt.ql | Simplifies hash-name exclusion. |
| java/ql/src/experimental/Security/CWE/CWE-598/SensitiveGetQuery.ql | Simplifies token-prefix exclusion. |
| java/ql/src/experimental/Security/CWE/CWE-555/PasswordInConfigurationFile.ql | Simplifies padding-suffix check. |
| java/ql/src/experimental/Security/CWE/CWE-094/SpringViewManipulationLib.qll | Simplifies Thymeleaf-class matching. |
| java/ql/src/experimental/Security/CWE/CWE-094/JythonInjection.ql | Simplifies compile-method matching. |
| java/ql/src/experimental/Security/CWE/CWE-094/InsecureDexLoading.qll | Simplifies storage-path matching. |
| java/ql/src/experimental/Security/CWE/CWE-073/JFinalController.qll | Simplifies attribute-getter matching. |
| java/ql/src/experimental/quantum/Examples/BrokenCrypto.ql | Simplifies algorithm-prefix exclusion. |
| java/ql/lib/semmle/code/java/Type.qll | Simplifies intersection-type detection. |
| java/ql/lib/semmle/code/java/security/XSS.qll | Simplifies print-method matching. |
| java/ql/lib/semmle/code/java/security/TaintedPermissionsCheckQuery.qll | Simplifies permission-name matching. |
| java/ql/lib/semmle/code/java/security/StaticInitializationVectorQuery.qll | Simplifies generator-class matching. |
| java/ql/lib/semmle/code/java/security/SpringBootActuatorsConfigQuery.qll | Simplifies version-prefix checks. |
| java/ql/lib/semmle/code/java/security/SensitiveActions.qll | Simplifies socket-type matching. |
| java/ql/lib/semmle/code/java/security/RsaWithoutOaepQuery.qll | Simplifies algorithm checks. |
| java/ql/lib/semmle/code/java/security/PartialPathTraversal.qll | Simplifies slash-suffix check. |
| java/ql/lib/semmle/code/java/security/InsecureRandomnessQuery.qll | Simplifies encoder-name matching. |
| java/ql/lib/semmle/code/java/security/InsecureBasicAuth.qll | Simplifies Basic-auth detection. |
| java/ql/lib/semmle/code/java/security/HttpsUrls.qll | Simplifies HTTP-prefix detection. |
| java/ql/lib/semmle/code/java/security/ExternalAPIs.qll | Simplifies JUnit-package matching. |
| java/ql/lib/semmle/code/java/security/ControlledString.qll | Simplifies trailing-quote detection. |
| java/ql/lib/semmle/code/java/security/ArbitraryApkInstallation.qll | Simplifies file-URL detection. |
| java/ql/lib/semmle/code/java/security/AndroidCertificatePinningQuery.qll | Simplifies URL-marker detection. |
| java/ql/lib/semmle/code/java/JMX.qll | Simplifies managed-bean matching. |
| java/ql/lib/semmle/code/java/frameworks/struts/StrutsConventions.qll | Simplifies convention-property matching. |
| java/ql/lib/semmle/code/java/frameworks/struts/StrutsActions.qll | Simplifies setter-name matching. |
| java/ql/lib/semmle/code/java/frameworks/stapler/Stapler.qll | Simplifies constructor-tag detection. |
| java/ql/lib/semmle/code/java/frameworks/spring/SpringProfile.qll | Simplifies profile-negation detection. |
| java/ql/lib/semmle/code/java/frameworks/spring/SpringAutowire.qll | Simplifies setter-name matching. |
| java/ql/lib/semmle/code/java/frameworks/Properties.qll | Simplifies store-method matching. |
| java/ql/lib/semmle/code/java/frameworks/Networking.qll | Simplifies URL-field matching. |
| java/ql/lib/semmle/code/java/frameworks/Lombok.qll | Simplifies Lombok-package matching. |
| java/ql/lib/semmle/code/java/frameworks/JoddJson.qll | Simplifies parser-name matching. |
| java/ql/lib/semmle/code/java/frameworks/JaxWS.qll | Simplifies Java-package exclusion. |
| java/ql/lib/semmle/code/java/frameworks/JAXB.qll | Simplifies accessor-name checks. |
| java/ql/lib/semmle/code/java/frameworks/jackson/JacksonSerializability.qll | Simplifies writer-name matching. |
| java/ql/lib/semmle/code/java/frameworks/j2objc/J2ObjC.qll | Simplifies comment-boundary checks. |
| java/ql/lib/semmle/code/java/frameworks/IoJsonWebToken.qll | Simplifies header-field matching. |
| java/ql/lib/semmle/code/java/frameworks/gwt/GwtXml.qll | Simplifies module-file detection. |
| java/ql/lib/semmle/code/java/frameworks/gwt/GwtUiBinderXml.qll | Simplifies template-file detection. |
| java/ql/lib/semmle/code/java/frameworks/Cucumber.qll | Simplifies annotation-package matching. |
| java/ql/lib/semmle/code/java/frameworks/Camel.qll | Simplifies bean-URI detection. |
| java/ql/lib/semmle/code/java/frameworks/android/XmlParsing.qll | Simplifies getter-name checks. |
| java/ql/lib/semmle/code/java/frameworks/android/SharedPreferences.qll | Simplifies put-method matching. |
| java/ql/lib/semmle/code/java/frameworks/android/Intent.qll | Simplifies intent-field matching. |
| java/ql/lib/semmle/code/java/frameworks/android/Compose.qll | Simplifies live-literal matching. |
| java/ql/lib/semmle/code/java/Element.qll | Simplifies stub-path detection. |
| java/ql/lib/semmle/code/java/dispatch/WrappedInvocation.qll | Simplifies stub-path detection. |
| java/ql/lib/semmle/code/java/deadcode/WebEntryPoints.qll | Simplifies GWT-package detection. |
| java/ql/lib/semmle/code/java/deadcode/StrutsEntryPoints.qll | Simplifies accessor-name checks. |
| java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll | Simplifies return-value validation. |
| java/ql/lib/semmle/code/java/Concurrency.qll | Simplifies pool-name exclusion. |
| java/ql/lib/experimental/quantum/Language.qll | Updates commented test-file check. |
| java/ql/integration-tests/kotlin/linux/use_java_library/parameterTypes.ql | Simplifies library-file matching. |
| java/ql/integration-tests/kotlin/linux/custom_plugin/diag.ql | Simplifies diagnostic-prefix check. |
| java/ql/integration-tests/kotlin/all-platforms/recursive_interfaces/types.ql | Simplifies interface-name matching. |
| java/ql/integration-tests/java/subst/file.ql | Simplifies URL exclusions. |
| java/ql/consistency-queries/visibility.ql | Simplifies default-method exclusion. |
| go/ql/test/library-tests/semmle/go/Types/ImplementsComparable.ql | Simplifies test-type matching. |
| go/ql/test/library-tests/semmle/go/Types/Aliases.ql | Simplifies fixture-path matching. |
| go/ql/test/library-tests/semmle/go/Packages/PackagePath.ql | Simplifies package-path checks. |
| go/ql/test/library-tests/semmle/go/frameworks/ElazarlGoproxy/test.ql | Simplifies source-name matching. |
| go/ql/test/extractor-tests/go1.14/interfaces.ql | Simplifies package-suffix check. |
| go/ql/src/Security/CWE-352/ConstantOauth2State.ql | Simplifies local-URL checks. |
| go/ql/src/Security/CWE-020/IncompleteUrlSchemeCheck.ql | Simplifies string-operation matching. |
| go/ql/src/InconsistentCode/MistypedExponentiation.ql | Simplifies numeric-prefix check. |
| go/ql/src/filters/ClassifyFiles.ql | Simplifies vendor-path detection. |
| go/ql/src/experimental/CWE-807/SensitiveConditionBypass.qll | Simplifies slash checks. |
| go/ql/src/experimental/CWE-285/PamAuthBypass.ql | Simplifies test-path checks. |
| go/ql/src/experimental/CWE-203/Timing.ql | Simplifies test-path exclusion. |
| go/ql/lib/semmle/go/frameworks/Zap.qll | Simplifies formatter-suffix check. |
| go/ql/lib/semmle/go/frameworks/SystemCommandExecutors.qll | Simplifies git-command matching. |
| go/ql/lib/semmle/go/frameworks/stdlib/TextTemplate.qll | Simplifies escape-function matching. |
| go/ql/lib/semmle/go/frameworks/stdlib/Regexp.qll | Simplifies replacement-function matching. |
| go/ql/lib/semmle/go/frameworks/Spew.qll | Simplifies formatter-suffix check. |
| go/ql/lib/semmle/go/frameworks/Protobuf.qll | Simplifies getter-name matching. |
| go/ql/lib/semmle/go/frameworks/Gqlgen.qll | Simplifies resolver-name matching. |
| go/ql/lib/semmle/go/Concepts.qll | Simplifies format-suffix check. |
| go/ql/integration-tests/root-internal-tests/test.ql | Simplifies test-function matching. |
| csharp/ql/test/library-tests/frameworks/ServiceStack/xssSink.ql | Simplifies stub-path exclusion. |
| csharp/ql/test/library-tests/frameworks/ServiceStack/sqlSink.ql | Simplifies stub-path exclusion. |
| csharp/ql/test/library-tests/frameworks/ServiceStack/remoteFlowSource.ql | Simplifies stub-path exclusion. |
| csharp/ql/test/library-tests/frameworks/ServiceStack/externalLocationSink.ql | Simplifies stub-path exclusion. |
| csharp/ql/test/library-tests/frameworks/ServiceStack/codeInjectionSinks.ql | Simplifies stub-path exclusion. |
| csharp/ql/test/library-tests/frameworks/NHibernate/StoredFlowSources.ql | Simplifies stub-path exclusion. |
| csharp/ql/test/library-tests/frameworks/NHibernate/SqlExprs.ql | Simplifies stub-path exclusion. |
| csharp/ql/test/library-tests/fields/Constants5.ql | Simplifies namespace matching. |
| csharp/ql/test/library-tests/expressions/ObjectCreation8.ql | Simplifies list-name matching. |
| csharp/ql/test/library-tests/csharp8/switchexprcontrolflow.ql | Simplifies callable-name matching. |
| csharp/ql/test/library-tests/csharp11/fileScoped.ql | Simplifies fixture-name matching. |
| csharp/ql/test/library-tests/csharp10/fileScopedNamespace.ql | Simplifies fixture-location matching. |
| csharp/ql/test/library-tests/controlflow/graph/Common.qll | Simplifies stub-path detection. |
| csharp/ql/src/utils/modeleditor/ModelEditor.qll | Simplifies test-path exclusion. |
| csharp/ql/src/Security Features/PersistentCookie.ql | Simplifies date-method matching. |
| csharp/ql/src/Security Features/CWE-327/InsecureSQLConnection.ql | Simplifies encryption-option checks. |
| csharp/ql/src/Security Features/CookieWithOverlyBroadDomain.ql | Simplifies leading-dot detection. |
| csharp/ql/src/experimental/Security Features/Serialization/DataSetSerialization.qll | Simplifies XML-reader matching. |
| csharp/ql/src/experimental/Security Features/backdoor/ProcessNameToHashTaintFlow.ql | Simplifies hash-method matching. |
| csharp/ql/src/Concurrency/UnsynchronizedStaticAccess.ql | Simplifies concurrent-type matching. |
| csharp/ql/src/Concurrency/Concurrency.qll | Simplifies lock-method matching. |
| csharp/ql/src/Bad Practices/UseOfSystemOutputStream.ql | Simplifies write-method matching. |
| csharp/ql/src/Bad Practices/Naming Conventions/VariableNameTooShort.ql | Simplifies event-argument matching. |
| csharp/ql/src/Bad Practices/Naming Conventions/DefaultControlNames.ql | Simplifies designer-file exclusion. |
| csharp/ql/src/ASP/BlockCodeResponseWrite.ql | Simplifies response-write detection. |
| csharp/ql/lib/semmle/code/csharp/security/dataflow/XSSSinks.qll | Simplifies URL-property matching. |
| csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsinks/ParallelSink.qll | Simplifies delegate-name matching. |
| csharp/ql/lib/semmle/code/csharp/security/dataflow/CodeInjectionQuery.qll | Simplifies compiler-method matching. |
| csharp/ql/lib/semmle/code/csharp/security/cryptography/HardcodedSymmetricEncryptionKey.qll | Simplifies encryption-kind matching. |
| csharp/ql/lib/semmle/code/csharp/security/auth/ActionMethods.qll | Simplifies event-argument matching. |
| csharp/ql/lib/semmle/code/csharp/frameworks/system/xml/XPath.qll | Simplifies selection-method matching. |
| csharp/ql/lib/semmle/code/csharp/frameworks/system/web/Mvc.qll | Simplifies redirect-method matching. |
| csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll | Simplifies string-class matching. |
| csharp/ql/lib/semmle/code/csharp/frameworks/JsonNET.qll | Simplifies serialization-method checks. |
| csharp/ql/lib/semmle/code/csharp/File.qll | Simplifies stub-path detection. |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll | Simplifies return-value validation. |
| csharp/ql/lib/semmle/code/csharp/Comments.qll | Simplifies code-suffix checks. |
| csharp/ql/lib/Linq/Helpers.qll | Simplifies enumerable-type matching. |
| csharp/ql/integration-tests/windows/subst/file.ql | Simplifies system-path exclusion. |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_fallback/CompilationInfo.ql | Simplifies diagnostic-key exclusion. |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error/CompilationInfo.ql | Simplifies diagnostic-key exclusion. |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error_timeout/CompilationInfo.ql | Simplifies diagnostic-key exclusion. |
| csharp/ql/integration-tests/posix/standalone_dependencies_nuget_clear/CompilationInfo.ql | Simplifies diagnostic-key exclusion. |
| csharp/ql/integration-tests/all-platforms/standalone_resx/CompilationInfo.ql | Simplifies diagnostic-key exclusion. |
| csharp/ql/integration-tests/all-platforms/standalone_dependency_dir/Assemblies.ql | Simplifies assembly-name matching. |
| cpp/ql/test/library-tests/variables/variables/variable.ql | Simplifies class-name checks. |
| cpp/ql/test/library-tests/types/wchar_t_typedef/wchar_t.ql | Simplifies wide-character-type matching. |
| cpp/ql/test/library-tests/types/__wchar_t/wchar_t.ql | Simplifies wide-character-type matching. |
| cpp/ql/test/library-tests/type_strings/exprs.ql | Simplifies value-suffix check. |
| cpp/ql/test/library-tests/odasa2646/cfi.ql | Simplifies literal-class matching. |
| cpp/ql/test/library-tests/ir/range-analysis/RangeAnalysis.ql | Simplifies space detection. |
| cpp/ql/test/library-tests/friends/friends/nesting.ql | Simplifies outer-class matching. |
| cpp/ql/test/library-tests/fields/fields/Fields.ql | Simplifies type-class matching. |
| cpp/ql/test/library-tests/dataflow/forwarding/test.ql | Simplifies space detection. |
| cpp/ql/test/library-tests/dataflow/dataflow-tests/guard-condition-regression-test.ql | Simplifies source-name matching. |
| cpp/ql/test/library-tests/dataflow/certain/test.ql | Simplifies space detection. |
| cpp/ql/test/library-tests/dataflow/asExpr/test.ql | Simplifies space detection. |
| cpp/ql/test/library-tests/dataflow/asExpr/test-indirect.ql | Simplifies space detection. |
| cpp/ql/test/library-tests/dataflow/asDefinition/test.ql | Simplifies space detection. |
| cpp/ql/test/library-tests/controlflow/guards/GuardsInline.ql | Simplifies space detection. |
| cpp/ql/test/library-tests/constants/constants/ints.ql | Simplifies literal-class matching. |
| cpp/ql/src/utils/modelgenerator/internal/CaptureModels.qll | Simplifies test-path checks. |
| cpp/ql/src/Security/CWE/CWE-327/OpenSslHeartbleed.ql | Simplifies memcpy-name matching. |
| cpp/ql/src/Security/CWE/CWE-313/CleartextSqliteDatabase.ql | Simplifies encryption-pragma matching. |
| cpp/ql/src/Security/CWE/CWE-022/TaintedPath.ql | Simplifies file-creation matching. |
| cpp/ql/src/Power of 10/Rule 8/UndisciplinedMacro.ql | Simplifies macro-token checks. |
| cpp/ql/src/Power of 10/Rule 5/AssertionDensity.ql | Simplifies function-macro detection. |
| cpp/ql/src/Power of 10/Rule 4/FunctionTooLong.ql | Simplifies function-macro detection. |
| cpp/ql/src/Power of 10/Rule 3/DynamicAllocAfterInit.ql | Simplifies initialization-prefix check. |
| cpp/ql/src/Metrics/Files/FTodoComments.ql | Simplifies TODO-marker detection. |
| cpp/ql/src/Metrics/Files/ConditionalSegmentConditions.ql | Simplifies header-guard checks. |
| cpp/ql/src/Likely Bugs/Leap Year/LeapYear.qll | Simplifies date-function matching. |
| cpp/ql/src/Likely Bugs/InconsistentCheckReturnNull.ql | Simplifies assertion-macro matching. |
| cpp/ql/src/jsf/4.20 Unions and Bit Fields/AV Rule 156.ql | Simplifies unnamed-member detection. |
| cpp/ql/src/jsf/4.07 Header Files/AV Rule 33.ql | Simplifies include-prefix check. |
| cpp/ql/src/jsf/4.06 Pre-Processing Directives/AV Rule 29.ql | Simplifies function-macro detection. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 25.ql | Simplifies time-header matching. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 24.ql | Simplifies stdlib-header matching. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 23.ql | Simplifies stdlib-header matching. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 22.ql | Simplifies stdio-header matching. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 21.ql | Simplifies signal-header matching. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 19.ql | Simplifies locale-header matching. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 18.ql | Simplifies stddef-header matching. |
| cpp/ql/src/jsf/4.05 Libraries/AV Rule 17.ql | Simplifies errno-header matching. |
| cpp/ql/src/JPL_C/LOC-2/Rule 05/HeapMemory.ql | Simplifies initialization-prefix check. |
| cpp/ql/src/JPL_C/LOC-2/Rule 03/LoopBounds.ql | Simplifies nontermination-marker detection. |
| cpp/ql/src/JPL_C/LOC-2/Rule 03/ExitNonterminatingLoop.ql | Simplifies nontermination-marker detection. |
| cpp/ql/src/external/examples/filters/ExcludeGeneratedCode.ql | Simplifies generated-path detection. |
| cpp/ql/src/experimental/Security/CWE/CWE-273/PrivilegeDroppingOutoforder.ql | Simplifies root-name matching. |
| cpp/ql/src/experimental/cryptography/example_alerts/WeakEncryption.ql | Simplifies AES-prefix check. |
| cpp/ql/src/Documentation/CommentedOutCode.qll | Simplifies documentation-line detection. |
| cpp/ql/src/Critical/ReturnValueIgnored.ql | Simplifies operator-name exclusion. |
| cpp/ql/src/Best Practices/Unused Entities/UnusedIncludes.ql | Simplifies debug-header exclusion. |
| cpp/ql/src/Best Practices/Exceptions/LeakyCatch.ql | Simplifies deletion-method matching. |
| cpp/ql/src/Best Practices/Exceptions/AccidentalRethrow.ql | Simplifies exception-name matching. |
| cpp/ql/lib/semmle/code/cpp/UserType.qll | Simplifies anonymous-type detection. |
| cpp/ql/lib/semmle/code/cpp/rangeanalysis/SimpleRangeAnalysis.qll | Simplifies debug-file selection. |
| cpp/ql/lib/semmle/code/cpp/models/implementations/Allocation.qll | Simplifies reallocation-name matching. |
| cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll | Simplifies return-value validation. |
| cpp/ql/lib/semmle/code/cpp/commons/Assertions.qll | Simplifies assertion-macro detection. |
| cpp/ql/lib/semmle/code/cpp/Comments.qll | Simplifies comment-prefix checks. |
| cpp/ql/lib/experimental/quantum/OpenSSL/LibraryDetector.qll | Simplifies OpenSSL-location matching. |
| cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll | Simplifies argument-name matching. |
| cpp/ql/lib/experimental/cryptography/utils/OpenSSL/LibraryFunction.qll | Simplifies OpenSSL-location matching. |
| cpp/ql/examples/snippets/todocomment.ql | Simplifies TODO detection. |
| actions/ql/src/Security/CWE-829/UnpinnedActionsTag.ql | Simplifies self-repository detection. |
| actions/ql/src/Security/CWE-571/ExpressionIsAlwaysTrueHigh.ql | Simplifies expression-delimiter checks. |
| actions/ql/src/Security/CWE-571/ExpressionIsAlwaysTrueCritical.ql | Simplifies expression-delimiter checks. |
| actions/ql/lib/codeql/files/FileSystem.qll | Simplifies absolute-path exclusion. |
| actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll | Simplifies base-reference exclusion. |
| actions/ql/lib/codeql/actions/security/PoisonableSteps.qll | Simplifies local-action detection. |
| actions/ql/lib/codeql/actions/security/OutputClobberingQuery.qll | Simplifies output-command detection. |
| actions/ql/lib/codeql/actions/PowerShell.qll | Simplifies shell-prefix check. |
| actions/ql/lib/codeql/actions/config/Config.qll | Simplifies owner-negation check. |
Review effort: Balanced (adaptive)
| @@ -2832,7 +2832,7 @@ module YAML { | |||
| ( | |||
| name = dep | |||
| or | |||
| name.matches("codeql/%") and | |||
| name.startsWith("codeql/") and | |||
There was a problem hiding this comment.
This seems like a valid thing to do. It's quite easy for ql-for-ql scans to stop extracting code properly and for no one to notice for a while.
paldepind
left a comment
There was a problem hiding this comment.
Looks good to me! 💯 (I did not look at the CI failures)

Summary
matchesandregexpMatchpatterns and inverse-append checks withstartsWith,contains, andendsWith.Validation
git diff --check