Repository navigation
Conversation
Remove the misspelled constructor-call, occurrence-count, and leap-year helper aliases identified by config/blame-deprecations.mjs. Retain the legacy data-flow libraries. Co-authored-by: Copilot <[email protected]> Copilot-Session: 7be1d7da-9061-47a8-bf98-b3169476add9
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The PR removes three public C++ QL predicates, creating a breaking change whose downstream consumer impact and release timing require human judgment.
No open issues 🎉
What changed in this PR
This PR removes three outdated, misspelled deprecated C++ QL helper predicates while retaining their correctly named replacements and legacy data-flow libraries.
Changes:
- Removes the deprecated leap-year and occurrence-count aliases.
- Removes the deprecated
getAContructorCallBoost.Asio alias. - Adds breaking-change notes documenting the removed predicates and their replacements.
| File | Description |
|---|---|
| cpp/ql/src/Likely Bugs/Leap Year/LeapYear.qll | Removes the misspelled deprecated leap-year helper alias. |
| cpp/ql/src/change-notes/2026-11-18-outdated-deprecations.md | Documents removal of the deprecated source-library leap-year and occurrence-count aliases. |
| cpp/ql/src/Best Practices/Magic Constants/MagicConstants.qll | Removes the misspelled deprecated occurrence-count alias. |
| cpp/ql/lib/semmle/code/cpp/security/boostorg/asio/protocols.qll | Removes the misspelled deprecated Boost.Asio constructor-call alias. |
| cpp/ql/lib/change-notes/2026-11-18-outdated-deprecations.md | Documents removal of the deprecated Boost.Asio constructor-call alias. |
Review effort: Lite (adaptive)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the misspelled constructor-call, occurrence-count, and leap-year helper aliases identified by config/blame-deprecations.mjs. Retain the legacy data-flow libraries.