Skip to content

C++: Remove outdated deprecated helper predicates - #23186

Open
jketema wants to merge 1 commit into
mainfrom
jketema/dep-cpp
Open

jketema wants to merge 1 commit into
mainfrom
jketema/dep-cpp

Conversation

@jketema

@jketema jketema commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Remove the misspelled constructor-call, occurrence-count, and leap-year helper aliases identified by config/blame-deprecations.mjs. Retain the legacy data-flow libraries.

Remove the misspelled constructor-call, occurrence-count, and leap-year helper aliases identified by config/blame-deprecations.mjs. Retain the legacy data-flow libraries.

Co-authored-by: Copilot <[email protected]>
Copilot-Session: 7be1d7da-9061-47a8-bf98-b3169476add9
@jketema
jketema marked this pull request as ready for review November 20, 2026 15:45
@jketema
jketema requested a review from a team as a code owner November 20, 2026 15:45
Copilot AI adaptive review requested due to automatic review settings November 20, 2026 15:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The PR removes three public C++ QL predicates, creating a breaking change whose downstream consumer impact and release timing require human judgment.

No open issues 🎉

What changed in this PR

This PR removes three outdated, misspelled deprecated C++ QL helper predicates while retaining their correctly named replacements and legacy data-flow libraries.

Changes:

  • Removes the deprecated leap-year and occurrence-count aliases.
  • Removes the deprecated getAContructorCall Boost.Asio alias.
  • Adds breaking-change notes documenting the removed predicates and their replacements.
File Description
cpp/​ql/​src/​Likely Bugs/​Leap Year/​LeapYear.qll Removes the misspelled deprecated leap-year helper alias.
cpp/​ql/​src/​change-notes/​2026-11-18-outdated-deprecations.md Documents removal of the deprecated source-library leap-year and occurrence-count aliases.
cpp/​ql/​src/​Best Practices/​Magic Constants/​MagicConstants.qll Removes the misspelled deprecated occurrence-count alias.
cpp/​ql/​lib/​semmle/​code/​cpp/​security/​boostorg/​asio/​protocols.qll Removes the misspelled deprecated Boost.Asio constructor-call alias.
cpp/​ql/​lib/​change-notes/​2026-11-18-outdated-deprecations.md Documents removal of the deprecated Boost.Asio constructor-call alias.

Review effort: Lite (adaptive)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants