Repository navigation
docker: Move images to Debian trixie and drop libpq from the runtime - #6790
Open
matthewdarwin wants to merge 1 commit into
Open
matthewdarwin wants to merge 1 commit into
matthewdarwin wants to merge 1 commit into
Conversation
Builds on graphprotocol#6701 (pinned digests, dependabot docker updates, no -dev packages in the runtime) and goes one step further: - golang, rust and debian bases move from bookworm to trixie, pinned by multi-arch digest (debian:trixie-slim is Debian 13.7). - The runtime no longer installs libpq: graph-node and graphman reach Postgres through diesel-async/tokio-postgres and do not link libpq (ldd shows only libgcc_s, libm and libc), and OpenSSL is vendored. Only ca-certificates and netcat-openbsd (for wait_for) remain. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #6701 (refresh base images,
--no-install-recommends, dependabot docker updates) and moves the image to Debian trixie. Related: #6686.golang:bookworm→golang:trixie,rust:bookworm→rust:trixie,debian:bookworm-20241111-slim→debian:trixie-slim(Debian 13.7), all pinned by multi-arch index digest; dependabot's docker ecosystem (from docker: Refresh base images and trim runtime dependencies #6701) keeps them current.lddon both binaries shows only libgcc_s, libm, libc and ld-linux, the same for the published v0.45.0 image, and there are noPQ*symbols. OpenSSL is vendored (store/postgres). The runtime installs onlyca-certificatesandnetcat-openbsd(forwait_for). This also drops krb5/ldap/sasl: 81 packages vs 91 withlibpq5and 107 in v0.45.0.rust-toolchain.toml(1.94.0) is still honoured: rustup inrust:trixieinstalls it duringcargo build.If you'd rather keep this in #6701, I'm happy to close this one — the trixie bases and the libpq removal are the only additions.
Testing
Built the
graph-nodeandgraph-node-debugtargets from this branch and ran both it and the publishedgraphprotocol/graph-node:v0.45.0against postgres:17 (-E UTF8 --locale=C), ipfs/kubo and anvil (--block-time 1):lddgraph-node / graphman, nothing "not found"graph-node --version/graphman --versionindexingStatuseson :8030graphman chain list(head advancing)tests/integration-tests/base(built with graph-cli) via :8020, synced and healthy, entities queryablegraphman infoca-certificates)lddresolvesTrivy 0.76.1:
libpq5(#6701's runtime list)The remaining fixable one is zlib1g CVE-2026-85091, already fixed in trixie-security and picked up by the next
trixie-slimdigest.perl-basestays (Essential, as discussed in #6686) at 5.40.1-6+deb13u1.Notes, not changed here
openssl-src 300.5.0+3.5.0, April 2025). It's compiled into the binaries, so OS-package scans can't see it; 3.5.x has had security releases since. That needs aCargo.lockbump rather than a base-image change./etc/image-inforecords the base image's defaultrustc(1.100.0 here, 1.97.1 in v0.45.0) instead of the toolchain the build used (1.94.0), because thatRUNruns outside the workspace. Pre-existing.🤖 Generated with Claude Code