Repository navigation
fix(cli): validate handlers in template and cached mappings - #2172
Open
yinbowen-dc wants to merge 1 commit into
Open
yinbowen-dc wants to merge 1 commit into
yinbowen-dc wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: a935bab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yinbowen-dc
force-pushed
the
codex/fix-2065-template-handler-validation
branch
from
November 18, 2026 09:27
9f13cdc to
a935bab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2065.
graph buildchecks handler exports for data sources but not templates. Also, a cached mapping returns before checking the handlers requested by the current manifest entry. Propagate the validation flag to templates and check both newly compiled and cached WASM outputs for each entry.Regression tests use a real small WASM module with a known function export and a mocked AssemblyScript compilation boundary. They cover missing handlers in fresh/cached templates and cached data sources, valid cache reuse, and explicitly disabled validation. Three tests fail against the original compiler; all five pass with this change. Includes a patch changeset.
Validation: compiler regression tests; CLI source TypeScript build; ESLint and Prettier on changed files. The full project
tsc --noEmitcurrently also includes an existing add-command fixture whose generated Gravity/schema imports are absent in a fresh checkout; that command was not green and is not claimed as passing.Prepared with AI assistance.