Repository navigation
fix(cli): normalize null fallback ABI parameter lists - #2173
Open
yinbowen-dc wants to merge 1 commit into
Open
yinbowen-dc wants to merge 1 commit into
yinbowen-dc wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 0f18f99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yinbowen-dc
force-pushed
the
codex/fix-1973-null-fallback-parameters
branch
from
November 18, 2026 09:27
a015f5a to
0f18f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1973.
Some block explorers return parameterless fallback entries with
inputs: nullandoutputs: null. Immutable defaults only replace missing fields, so the null value reaches.mapduring call signature/type generation and aborts codegen. Normalize nullish fallback parameter arrays when loading the ABI, preserving ordinary named function parameters and the existing DefaultCall class naming.Added tests for null, omitted and empty fallback arrays alongside a normal withdraw function. The null fixture fails on main. All four ABI/codegen tests pass after the change, the CLI source TypeScript build passes, and changed files pass ESLint/Prettier. Includes a patch changeset.
Prepared with AI assistance.