Skip to content

fix(cli): validate directory paths before fetching contract info - #2175

Open
yinbowen-dc wants to merge 1 commit into
graphprotocol:mainfrom
yinbowen-dc:codex/fix-1857-early-directory-warning
Open

yinbowen-dc wants to merge 1 commit into
graphprotocol:mainfrom
yinbowen-dc:codex/fix-1857-early-directory-warning

Conversation

@yinbowen-dc

Copy link
Copy Markdown

Addresses #1857.

Both interactive init forms currently validate only that the directory is nonempty. If it already exists, users find out only after completing the remaining prompts and contract lookups. Validate existing paths at the directory prompt so the user can choose another location immediately, following the suggestion in the issue discussion.

The validator also rejects regular files and accepts not-yet-created nested directories. Existing fully specified command-line initialization still reaches its existing overwrite confirmation. This patch targets the early directory check; it does not claim to reproduce or fix the historical “no error?” message on current main.

Added five filesystem cases; all 14 subgraph helper tests pass. CLI source TypeScript build and changed-file ESLint/Prettier checks pass. Includes a patch changeset.

Prepared with AI assistance.

@changeset-bot

changeset-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca63117

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yinbowen-dc
yinbowen-dc force-pushed the codex/fix-1857-early-directory-warning branch from 8e6ce41 to ca63117 Compare November 18, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant