Repository navigation
fix(cli): validate directory paths before fetching contract info - #2175
Open
yinbowen-dc wants to merge 1 commit into
Open
yinbowen-dc wants to merge 1 commit into
yinbowen-dc wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: ca63117 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yinbowen-dc
force-pushed
the
codex/fix-1857-early-directory-warning
branch
from
November 18, 2026 09:27
8e6ce41 to
ca63117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1857.
Both interactive init forms currently validate only that the directory is nonempty. If it already exists, users find out only after completing the remaining prompts and contract lookups. Validate existing paths at the directory prompt so the user can choose another location immediately, following the suggestion in the issue discussion.
The validator also rejects regular files and accepts not-yet-created nested directories. Existing fully specified command-line initialization still reaches its existing overwrite confirmation. This patch targets the early directory check; it does not claim to reproduce or fix the historical “no error?” message on current main.
Added five filesystem cases; all 14 subgraph helper tests pass. CLI source TypeScript build and changed-file ESLint/Prettier checks pass. Includes a patch changeset.
Prepared with AI assistance.