Repository navigation
Name what enforces the test, comment, extension and return value rules in the rule table - #954
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
Agents working in graphql-java-tools keep repeating the same mistakes, and the repo should change so a change that looks right from one file is right for the whole repo. The rule table in
AGENTS.mdis how an agent tells which rules a check enforces and which ones depend on reading. Four PRs merged intoagent-friendlybefore the table existed, so their rows either say "docs only" for a rule a check now enforces or aren't there at all. That's the wrong signal.Description
Docs only,
AGENTS.md:CommentConventionsTest: what it fails on (issue numbers outside the TODO form, its history phrases,@sinceand "since 1.2.0"), thelint-allowescape and its 90 day cap. History in other words and comments that repeat the code stay docs only. The matching bullet under "Rules that need judgment" says the same, since it claimed no check covers it**/*include,failIfNoTests, and-Xassertions=always-enableon the Kotlin test compile. It also says what gets past:-DfailIfNoTests=false, and a test that asserts nothingTypeExtensionTest, whose every-kind schema fails when a built type is missing anything from an extension, however the code read it. That covers the reflection hole the boundary test has, for the types it buildsI left the resolver rows alone since the resolver plan PR rewrites them.
ReturnValueUnwrappingTestalready has its row from the unwrapping PRs, so the bounded check only shows up here for the neighbouring shapes rule.No release note, nothing changes for library users.
Checklist
Docs only. I checked each row against
pom.xml,CommentConventionsTest,Check.javaandTypeExtensionTestonagent-friendly.mvn clean verifypasses on JDK 17.