Repository navigation
Conversation
khomenkd
force-pushed
the
khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker
branch
2 times, most recently
from
November 18, 2026 10:22
653fa9a to
f46b3c4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1734 +/- ##
==========================================
+ Coverage 80.45% 80.46% +0.01%
==========================================
Files 358 358
Lines 14443 14443
Branches 1581 1581
==========================================
+ Hits 11620 11621 +1
Misses 2180 2180
+ Partials 643 642 -1 🚀 New features to boost your workflow:
|
khomenkd
marked this pull request as ready for review
November 19, 2026 16:25
Blocking SIGPIPE at library load changes the caller's signal mask, which can interfere with unrelated application behavior, including writing to closed pipes. Limit SIGPIPE blocking to the SDK cURL worker so the application thread that loads the SDK keeps its existing signal mask. Relates-To: DATASDK-112 Signed-off-by: Denys Khomenko <[email protected]>
khomenkd
force-pushed
the
khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker
branch
from
November 20, 2026 11:51
f46b3c4 to
1a61b2f
Compare
Explain why the cURL worker blocks SIGPIPE: certain cURL and OpenSSL combinations can terminate the process when writing to a closed socket. Keeping this rationale helps preserve the intent of the signal handling. Relates-To: DATASDK-112 Signed-off-by: Khomenko Denys <[email protected]>
khomenkd
force-pushed
the
khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker
branch
from
November 20, 2026 12:17
1a61b2f to
33c9ec7
Compare
rustam-gamidov-here
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the library-load-time SIGPIPE mask change and block the signal when the SDK cURL worker starts. This avoids changing the application thread’s signal mask; log failures to apply the mask.
Relates-To: DATASDK-112