Skip to content

Block SIGPIPE only on the OLP SDK cURL worker - #1734

Open
khomenkd wants to merge 2 commits into
masterfrom
khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker
Open

khomenkd wants to merge 2 commits into
masterfrom
khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker

Conversation

@khomenkd

Copy link
Copy Markdown
Contributor

Remove the library-load-time SIGPIPE mask change and block the signal when the SDK cURL worker starts. This avoids changing the application thread’s signal mask; log failures to apply the mask.

Relates-To: DATASDK-112

@khomenkd
khomenkd force-pushed the khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker branch 2 times, most recently from 653fa9a to f46b3c4 Compare November 18, 2026 10:22
@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.46%. Comparing base (72d1d34) to head (33c9ec7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
+ Coverage   80.45%   80.46%   +0.01%     
==========================================
  Files         358      358              
  Lines       14443    14443              
  Branches     1581     1581              
==========================================
+ Hits        11620    11621       +1     
  Misses       2180     2180              
+ Partials      643      642       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khomenkd
khomenkd marked this pull request as ready for review November 19, 2026 16:25
Blocking SIGPIPE at library load changes the caller's signal mask,
which can interfere with unrelated application behavior, including
writing to closed pipes.

Limit SIGPIPE blocking to the SDK cURL worker so the application
thread that loads the SDK keeps its existing signal mask.

Relates-To: DATASDK-112

Signed-off-by: Denys Khomenko <[email protected]>
@khomenkd
khomenkd force-pushed the khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker branch from f46b3c4 to 1a61b2f Compare November 20, 2026 11:51
Explain why the cURL worker blocks SIGPIPE: certain cURL and OpenSSL
combinations can terminate the process when writing to a closed socket.
Keeping this rationale helps preserve the intent of the signal handling.

Relates-To: DATASDK-112
Signed-off-by: Khomenko Denys <[email protected]>
@khomenkd
khomenkd force-pushed the khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker branch from 1a61b2f to 33c9ec7 Compare November 20, 2026 12:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants