Repository navigation
feat(query): accept --dialect clickhouse - #370
Merged
Merged
Conversation
The server accepts ClickHouse SQL on the dialect flag (runtimedb#1759); the CLI checked the value against its own list first and refused it. Add it to `query` and `databases query`, and to the README and skill.
eddietejeda
requested review from
anoop-narang
and removed request for
a team
November 12, 2026 01:27
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server accepts ClickHouse SQL on the
dialectflag since hotdata-dev/runtimedb#1759. The CLI validated--dialectagainst its own list (hotsql, duckdb, postgres, snowflake) and rejectedclickhousebefore sending anything.clickhouseis added to--dialectonhotdata queryandhotdata databases query.SKILL.mdandsubskills/analytics) now list it, withcountIf(...)as the ClickHouse example.Testing
query_accepts_each_server_dialecttest: both commands parse every dialect the server accepts, and an unknown one (mysql) is still rejected.cargo test(588 + integration),cargo clippy --all-targetsandcargo fmt --checkpass.