Repository navigation
fix(proxy): use port 80 for http:// destinations without a port - #351
Merged
seanmonstar merged 1 commit intoNov 16, 2026
Merged
Conversation
Tunnel, SocksV4 and SocksV5 fell back to 443 whenever the destination had no explicit port, so http://example.com/ was sent to example.com:443. Default by scheme instead, the same way HttpConnector does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tunnel, SocksV4 and SocksV5 fell back to 443 whenever the destination had no explicit port, so http://example.com/ was sent to example.com:443. Default by scheme instead, the same way HttpConnector does.