Repository navigation
perf(pool): binary search for Cache waiters - #352
Merged
seanmonstar merged 1 commit intoNov 16, 2026
Merged
Conversation
store_waker runs on every poll of a CacheFuture and cancel_waiter on every drop, and both scanned the whole waiter queue under the lock. With many callers parked that gets quadratic: polling 30k waiters once took ~150ms. Waiter ids only grow and are pushed to the back, so the queue is sorted and a binary search finds them. Same run now takes under 1ms. The id is u64 so it can't wrap on 32-bit targets.
seanmonstar
approved these changes
Nov 16, 2026
seanmonstar
left a comment
Member
There was a problem hiding this comment.
Simple improvement, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store_waker runs on every poll of a CacheFuture and cancel_waiter on every drop, and both scanned the whole waiter queue under the lock. With many callers parked that gets quadratic: polling 30k waiters once took ~150ms.
Waiter ids only grow and are pushed to the back, so the queue is sorted and a binary search finds them. Same run now takes under 1ms. The id is u64 so it can't wrap on 32-bit targets.