Skip to content

fix(http1): release oversized server read buffers between requests - #4278

Draft
hallerite wants to merge 1 commit into
hyperium:masterfrom
hallerite:codex/release-http1-server-read-buffer
Draft

hallerite wants to merge 1 commit into
hyperium:masterfrom
hallerite:codex/release-http1-server-read-buffer

Conversation

@hallerite

Copy link
Copy Markdown

After a large HTTP/1 upload, a server connection can hold an empty read buffer for as long as the application takes to produce its response. The last body read may have increased the adaptive read size. When the connection checks for EOF or the start of a pipelined request, it reserves that size before polling the socket. If the socket returns Pending, the allocation stays live. The cost adds up across concurrent connections even when every request body has been consumed.

This change releases an oversized empty buffer and resets the adaptive read size before the server's mid-message EOF check. Future reads can grow up to the configured maximum. If the buffer contains any pipelined bytes, the connection keeps them.

The regression test covers buffer release, preservation of pipelined bytes, and the configured maximum. The library, client, integration, and server tests passed with the full feature set.

After consuming a large request body, the EOF probe can reserve the last adaptive read size while the application is preparing its response. Release oversized empty buffers and restart adaptive reads at the initial size. Preserve unread pipelined bytes and the configured maximum.
@hallerite
hallerite marked this pull request as draft November 19, 2026 17:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant