Repository navigation
Conversation
After consuming a large request body, the EOF probe can reserve the last adaptive read size while the application is preparing its response. Release oversized empty buffers and restart adaptive reads at the initial size. Preserve unread pipelined bytes and the configured maximum.
hallerite
marked this pull request as draft
November 19, 2026 17:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a large HTTP/1 upload, a server connection can hold an empty read buffer for as long as the application takes to produce its response. The last body read may have increased the adaptive read size. When the connection checks for EOF or the start of a pipelined request, it reserves that size before polling the socket. If the socket returns
Pending, the allocation stays live. The cost adds up across concurrent connections even when every request body has been consumed.This change releases an oversized empty buffer and resets the adaptive read size before the server's mid-message EOF check. Future reads can grow up to the configured maximum. If the buffer contains any pipelined bytes, the connection keeps them.
The regression test covers buffer release, preservation of pipelined bytes, and the configured maximum. The library, client, integration, and server tests passed with the full feature set.