Repository navigation
Don't copy ScalarNonlinearFunction in VectorOfConstraints - #2803
Merged
Merged
Conversation
Member
|
I think the first step before we go making any changes to this is to come up with a large suite of benchmarks and tests. There are a number of subtle behaviors here. |
3 tasks done
blegat
force-pushed
the
bl/copy_nl
branch
2 times, most recently
from
November 3, 2026 10:05
3a0669a to
2a1d4a2
Compare
blegat
marked this pull request as ready for review
November 3, 2026 10:05
Member
Author
|
Reusing |
Member
Author
|
After this, there are two places left when aliases can be destroyed, if |
Functions such as `ScalarNonlinearFunction` cannot be modified in-place through the MOI API, so models do not need to copy them. Copying them turns shared subexpressions into distinct objects, which prevents `Nonlinear.ReverseAD` from detecting them as common subexpressions. * Add `Utilities.copy_if_modifiable`, which defaults to `copy` and returns the function itself for `VariableIndex`, `VectorOfVariables`, `ScalarNonlinearFunction` and `VectorNonlinearFunction`. * Use it in `VectorOfConstraints`, `ObjectiveContainer`, `UniversalFallback`, `SplitIntervalBridge` and `Utilities.canonical`. * Document it in `AbstractFunction`, `ScalarNonlinearFunction`, `VectorNonlinearFunction` and the implementing tutorial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #2788
I'm not too convinced by the current approach.
For the
copyinConstraintFunction, I think we add it mostly to be extra-sure the user does not alter the function but we don't really need it in the context ofMOI.copy_tosinceadd_constraintspecifies that the model should have its own copy. Maybe we should also haveUnsafeConstraintFunctionthat is used insideMOI.copy_to, it should also safe wasteful copies forScalarAffineFunctionandScalarQuadraticFunction. So if we have tests that checks that solvers have their own copies inadd_constraintthen it should be safe.