Repository navigation
Fix dead links in the Knative docs - #6798
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
Update five links that return 404: - Fluent Bit Kubernetes install guide moved under /installation/downloads/ - the RBAC link had a stray "AC" path segment - the JSONata documentation page moved to docs.jsonata.org - the knative/client and knative/func development guides are now at the repository root
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: farisbasha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @farisbasha! It looks like this is your first PR to knative/docs 🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five links in the docs return 404, so readers following them land on a "page not found".
Proposed Changes
docs/snippets/collecting-logs.md: the Fluent Bit Kubernetes guide moved tohttps://docs.fluentbit.io/manual/installation/downloads/kubernetesdocs/versioned/install/README.md: remove the strayACfrom the RBAC link (.../rbac/AC->.../rbac/)docs/versioned/eventing/transforms/event-transform-jsonata.md:jsonata.org/documentation.html->https://docs.jsonata.org/overview.htmldocs/community/contributing.md: the knative/client and knative/func development guides now live at the repository root (DEVELOPMENT.mdandCONTRIBUTING.md)I checked each new URL with
curl -sI(no redirect following): all return 200. The old ones return 404. The KServe links are left alone because #6795 already fixes them.I used an AI assistant to help find these links.