Repository navigation
update: bump russh and ssh-key to clear RUSTSEC-2023-0071 - #362
Merged
Merged
Conversation
russh 0.65.1 pinned rsa =0.10.0-rc.18, and prerelease versions sort below the patched rsa 0.10.0, so cargo audit and cargo deny kept reporting the Marvin timing advisory. russh 0.65.2 depends on rsa ^0.10 and ssh-key =0.7.0-rc.12, which resolves rsa 0.10.0 and pkcs1 0.8.0 stable. Bump russh to 0.65.2 and the ssh-key pin to =0.7.0-rc.12 to match it, and drop the now-unneeded RUSTSEC-2023-0071 suppression from .cargo/audit.toml. russh-sftp 3.0.1 only uses russh as a dev-dependency and needs no change. Validated with clippy -D warnings and cargo test --all-features (2739 pass, including the 66 certificate tests). The 4 integration_test failures come from the local SSH agent having no identities and fail the same way on main. cargo deny check advisories no longer reports RUSTSEC-2023-0071. Closes #361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
russh 0.65.1 pinned
rsa = "=0.10.0-rc.18", which sorts below the patched rsa 0.10.0, so RUSTSEC-2023-0071 (Marvin timing side channel) kept firing and was suppressed in.cargo/audit.toml. russh 0.65.2 (crates.io, 2026-11-16) ships the upstream fix and depends onrsa ^0.10andssh-key =0.7.0-rc.12.=0.7.0-rc.12to match it.Cargo.locknow resolves rsa 0.10.0 and pkcs1 0.8.0 stable.Validation:
cargo clippy --all-targets --all-features -- -D warningspasses.cargo test --all-features --no-fail-fastpasses 2739 tests, including the 66 certificate tests (ssh-key rc.12 rejects certificate keys used as CA keys). The 4integration_testfailures come from the local SSH agent having no identities and fail identically on main.cargo deny check advisoriesno longer reports RUSTSEC-2023-0071; it still reports the unrelated RUSTSEC-2026-0543 (chrono unmaintained), which is present on main too.cargo auditwas not run locally (not installed).Closes #361