You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bump the kurtosis battery's ethereum-package pin to a launcher that passes beacon --bootnodes as a list #850
At that commit, src/cl/ethlambda/ethlambda_launcher.star in lambdaclass/ethereum-package writes the resolved bootnodes to /tmp/ethlambda-bootnodes.txt and passes --bootnodes=/tmp/ethlambda-bootnodes.txt (lines 17-19 and 173-186).
So once #825 is on main, the battery's push runs fail at beacon startup whenever the launcher has a bootnode to pass.
Why it is not in #825. On pull_request the workflow tests ghcr.io/lambdaclass/ethlambda:unstable, which is main's image, not the PR's. A pin bump inside #825 would trigger a run that pairs the list-passing launcher with a binary that still reads a file, and fail. The bump only makes sense once that PR is on main and in unstable.
Fix. Set ETHEREUM_PACKAGE_REF to 1aec42f3fdd934ef0520f535630fe86eec30cfe0, or a later commit of the fork's add-ethlambda branch (head today: 860b338622). That commit is "refactor: pass ethlambda's bootnodes as a comma-separated list", and it passes --bootnodes=<comma-joined ENRs> through cl_shared.append_bootnode_arg. It is 16 commits ahead of 67cb0e02 (the builder wiring, reporting ethlambda's ENR and TCP multiaddr, the image tag among them), so the battery run on the bump's own PR is what checks those against main.
Activity