Repository navigation
perf(beacon): back the participation lists and pending deposits with persistent trees #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,432
−191
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8529fe0
perf(beacon): back the participation lists and pending deposits with …
MegaRedHand 6de4728
feat(ssz-tree): add a blind set, a sorted reader and a shared-node re…
MegaRedHand 099d568
test(types): add ignored benchmarks for the attestation pass and the …
MegaRedHand d08f731
perf(beacon): write participation flags blindly in process_attestation
MegaRedHand c67f224
perf(beacon): read an attestation's participation flags with a sorted…
MegaRedHand fb7b208
perf(beacon): build the rotated participation list by sharing one zer…
MegaRedHand ef181c7
Merge main into perf/tree-backed-participation
MegaRedHand 0960567
Merge main into perf/tree-backed-participation
MegaRedHand 16813b0
Merge main into perf/tree-backed-participation
MegaRedHand 57f9e89
Merge main into perf/tree-backed-participation
MegaRedHand 4608ddf
Merge main into perf/tree-backed-participation
MegaRedHand 3a939ad
Merge main into perf/tree-backed-participation
MegaRedHand 6ce4b76
Merge main into perf/tree-backed-participation
MegaRedHand ca69a1d
fix(ssz-tree): keep a progressive sorted reader right after a step back
MegaRedHand 46cc758
docs(beacon): name the check that makes the sorted reader and blind w…
MegaRedHand 74690a0
refactor(types): match gloas first in rebase_participation_on, and do…
MegaRedHand 109b8f8
Merge remote-tracking branch 'origin/perf/tree-backed-participation' …
MegaRedHand 0428fb8
docs(beacon): describe the tree-backed participation lists and pendin…
MegaRedHand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The epoch code takes the whole queue out here, and
set_pending_depositsbuilds a fresh tree from theVec(single_pass.rs:535,stf/epoch/electra.rs:540). So every epoch boundary copies every pending deposit and discards all the cached hashes, even when no deposit was applied or postponed. Whenremainingis the queue unchanged, leaving the list in place would keep its root.to_vec()here also clones each deposit whereinto_inner()used to move it.Could this be part of the
process_epochregression?