Repository navigation
Fix flaky never-recorded-facts close test - #1235
Merged
tankyleo merged 1 commit intoNov 13, 2026
Merged
Conversation
a_close_is_classified_for_a_channel_whose_facts_were_never_recorded restarts node_a, reconnects the peers, and immediately calls close_channel. If channel reestablish has not completed yet, LDK rejects the close and the test panics with ChannelClosingFailed, as seen on the macOS CI leg. Wait for the channel to report is_usable after reconnecting before closing. AI tooling (Claude Code) was used to diagnose and fix this test. Co-Authored-By: Claude Fable 5 <[email protected]>
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tankyleo
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a_close_is_classified_for_a_channel_whose_facts_were_never_recordedrestartsnode_a, reconnects the peers, and immediately callsclose_channel. If channel reestablish has not completed yet, LDK rejects the close and the test panics withChannelClosingFailed, as seen on the macOS CI leg. Wait for the channel to reportis_usableafter reconnecting before closing.AI tooling (Claude Code) was used to diagnose and fix this test.