Repository navigation
fix: keep notification center visible on screenshot grab - #1826
Open
18202781743 wants to merge 1 commit into
Open
18202781743 wants to merge 1 commit into
18202781743 wants to merge 1 commit into
Conversation
Reviewer's GuideUIChange the notification center from a Qt.Tool window to a frameless Qt.Window so it remains visible during screenshot capture.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="panels/notification/center/package/main.qml" line_range="93" />
<code_context>
// visible: true
visible: Panel.visible
- flags: Qt.Tool
+ flags: Qt.Window | Qt.FramelessWindowHint
property int contentPadding: 10
</code_context>
<issue_to_address>
**Notification center enters task switcher**
When the notification center is shown on a desktop whose window manager lists ordinary top-level windows in the taskbar or Alt+Tab, `Qt.Window` gives the notification center ordinary top-level window behavior instead of the `Qt.Tool` type, so window managers that list ordinary windows expose it in the taskbar and Alt+Tab while it is open. The panel then appears as a user-switchable application window.
Preserve the no-taskbar/no-task-switcher behavior explicitly while using a window type that receives the required focus hook.
</issue_to_address>
|
BLumia
reviewed
Nov 18, 2026
18202781743
force-pushed
the
master
branch
3 times, most recently
from
November 19, 2026 04:51
f80a731 to
4d4d304
Compare
1. Change notification center window flags from Qt.Tool to Qt.Window | Qt.FramelessWindowHint 2. Align notification center behavior with the window-mode launcher so it is not unmapped during Ctrl+Alt+A screenshot grabs 3. Avoid the Qt.Tool path that misses focus hooks in qt5platform-plugins and falls back to the Qt XCB default handler clearing the active window after ~100ms 4. PMS: BUG-383559 Influence: 1. Verify long-press Ctrl+Alt+A captures the notification center in the screenshot preview 2. Confirm click-outside still closes the notification center 3. Check taskbar and Alt+Tab display of the notification center 4. Verify window stacking order and z-order behavior 5. Test multi-screen scenarios 6. Test Wayland LayerShell behavior 7. Confirm launcher and clipboard screenshot behavior unchanged 8. Reproduce manually rather than via fast simulated key presses fix: 修复截图抓取时通知中心消失问题 1. 将通知中心窗口 flags 从 Qt.Tool 改为 Qt.Window | Qt.FramelessWindowHint 2. 使通知中心行为与窗口模式启动器保持一致,避免在 Ctrl+Alt+A 截图时被取 消映射 3. 规避 Qt.Tool 在 qt5platform-plugins 中缺少焦点钩子、退回 Qt XCB 默认 处理并在约 100ms 后清除活动窗口的问题 4. PMS: BUG-383559 Influence: 1. 验证长按 Ctrl+Alt+A 时截图预览包含通知中心 2. 确认点击外部仍可关闭通知中心 3. 检查任务栏和 Alt+Tab 中通知中心的显示 4. 验证窗口层级与叠放顺序 5. 测试多屏场景 6. 测试 Wayland LayerShell 行为 7. 确认启动器和剪贴板截图行为未受影响 8. 请手动复现,避免使用快速模拟按键 Log: Fixed missing notification center in Ctrl+Alt+A screenshots Log: 修复通知中心快捷键截图缺失 PMS: BUG-383559
mhduiy
approved these changes
Nov 19, 2026
BLumia
approved these changes
Nov 19, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt.Window | Qt.FramelessWindowHint
screenshots triggered by Ctrl+Alt+A
NotifyGrab at 31ms and UnmapNotify at 127ms
Qt.Widget, Qt.Window and Qt.Dialog, missing Qt.Tool
the Qt XCB default handler clears active window after ~100ms
Log: 修复通知中心快捷键截图缺失
Influence:
the screenshot preview
fix: 修复截图抓取时通知中心消失问题
Qt.Window | Qt.FramelessWindowHint
127ms 产生 UnmapNotify
安装焦点钩子,遗漏 Qt.Tool
在约 100ms 后清除活动窗口
Log: 修复通知中心快捷键截图缺失
Influence:
PMS: BUG-383559
Summary by Sourcery
Ensure the notification center remains available during screenshot capture by treating it as a standard frameless window instead of a tool window.
Bug Fixes:
Enhancements: