Repository navigation
[2500u3] fix: keep shell notification and OSD settings private - #1827
Merged
xujin177 merged 1 commit intoNov 19, 2026
Merged
Conversation
1. Mark 7 audited keys private across 2 DConfig schemas. 2. Preserve shared public interfaces and uninstalled source copies. 3. Keep values, flags, permissions and business logic unchanged. Log: No user-facing changes Influence: 1. Validate that all changed DConfig schemas load without JSON errors. 2. Open display OSD and notifications and verify settings persist. 3. Verify retained public and excluded keys match the audit workbook. fix: 通知和OSD内部配置声明为private 1. 按审查表将2份DConfig定义中的7个属性声明为private。 2. 保留跨应用共享public接口及当前构建不安装的旧定义。 3. 不修改默认值、flags、permissions或业务逻辑。 Influence: 1. 校验所有改动的DConfig JSON可正常解析和加载。 2. 打开显示OSD和通知,确认展示及设置持久化正常。 3. 对照审查表确认保留的public属性和排除项未被修改。 Log: 无用户可见变化 PMS: TASK-398753 (cherry picked from commit 0ba669a)
Reviewer's GuideAPIMark the seven audited notification and OSD DConfig properties private while preserving the other schema declarations.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
18202781743
approved these changes
Nov 19, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, xujin177 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
将已合入 master 的 DConfig 审查修复移植到
develop/2500u3。0ba669a70897cea3ec82ddd593f1aaeae8f0606bgit cherry-pick -x,当前 PR 仅包含 1 个提交。visibility: public → private。按DConfig审查表收敛dde-shell的内部配置声明:共7个键、2份JSON从public改为private。
public表示提供给其他应用直接访问,private表示应用内部使用。外部通过D-Bus使用功能、只读取同JSON其他属性、同宿主插件或已无有效业务消费的配置,按表内逐键结论处理。
panels/notification/osd/configs/org.deepin.dde.shell.osd.jsonhideDuplicateMode、hideExtendMode、hideSingleModepanels/notification/server/configs/org.deepin.dde.shell.notification.jsonbubbleContentRowCount、maxCount、notificationCleanupDays、notificationClosed保留接口/排除项:shared notification controls and appsInfo。表中判为合理的public以及未安装旧副本均不调整。
仅修改上述JSON的visibility;默认值、serial、flags、permissions、键名和业务逻辑均不变。
这是接口声明收敛,不宣称仅改private已实现运行时访问隔离。
验证:全部改动JSON解析通过;逐键语义差异及逐行diff确认只包含表中visibility变化;
git diff --check通过。运行时回归建议见提交信息Influence;本次未启动或修改运行中的桌面配置。
PMS: TASK-398753
Summary by Sourcery
Enhancements: