Repository navigation
fix(dock): restore Wayland edge reveal - #1830
Merged
Merged
Conversation
1. Set dock visibility from the completed Wayland animation direction. 2. Save compositor-reported sizes only during an active dock drag. Log: Keep delayed animation sizes out of dock settings. Influence: X11 behavior is unchanged. fix(dock): 修复 Wayland 任务栏边缘唤出 1. 按 Wayland 动画完成时的方向设置任务栏可见性。 2. 仅在拖拽任务栏时保存合成器回报的尺寸。 Log: 避免迟到的动画尺寸写入任务栏设置。 PMS: TASK-398935 Influence: 不改变 X11 行为。
Reviewer's GuideImplementationSet dock visibility from the Wayland hide/show animation direction when it finishes, avoiding late geometry updates overriding the result.
Persist compositor-reported dock sizes only while the dock is actively being dragged and resized.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="panels/dock/package/main.qml" line_range="898" />
<code_context>
target: dock
enabled: dock.compositorDrivenResize
+ // Wayland can apply animation geometry after the animation stops.
+ && dock.isDragging && Applet.isResizing
&& !hideShowAnimation.running
&& !dockAnimation.running
</code_context>
<issue_to_address>
**Stale dock size is saved**
When a hide/show configure remains pending after its animation stops while a compositor resize is active, the resize `Connections` handler treats the pending geometry as a resize update and writes the stale dimension to `Applet.dockSize`, which `finishResize()` then saves as the dock setting.
Exclude pending hide/show configure geometry from resize updates.
</issue_to_address>
### Comment 2
<location path="panels/dock/package/main.qml" line_range="898" />
<code_context>
target: dock
enabled: dock.compositorDrivenResize
+ // Wayland can apply animation geometry after the animation stops.
+ && dock.isDragging && Applet.isResizing
&& !hideShowAnimation.running
&& !dockAnimation.running
</code_context>
<issue_to_address>
**Final resize size is lost**
When the compositor emits `resizing=false` before delivering the final resize configure, the resize-end handler clears `dock.isDragging` and `finishResize()` saves the last known size; the later configure is ignored because this `Connections` handler is disabled, so the final dragged size is not persisted.
Keep tracking the drag's final configure until it is applied, or otherwise defer persisting the final size until the compositor's last geometry update is received.
</issue_to_address>
Contributor
Author
|
/test all |
|
18202781743
approved these changes
Nov 19, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1829 to
develop/2500u3.Verification: the identical QML previously passed a nested Treeland smoke test: two bottom-edge reveals kept the configured 65 px size; dragging saved 81 px.
PMS: TASK-398935
Summary by Sourcery
Restore Wayland dock edge reveal behavior while preserving configured sizes across compositor updates.
Bug Fixes: