Skip to content

fix(dock): guard DockPanel::geometry() against null window - #1831

Open
pengfeixx wants to merge 1 commit into
linuxdeepin:masterfrom
pengfeixx:fix/dock-panel-geometry-null-safety
Open

pengfeixx wants to merge 1 commit into
linuxdeepin:masterfrom
pengfeixx:fix/dock-panel-geometry-null-safety

Conversation

@pengfeixx

@pengfeixx pengfeixx commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem

DockPanel::geometry() dereferences window() without a runtime null check:

QRect DockPanel::geometry()
{
    Q_ASSERT(window());          // no-op in release builds
    return window()->geometry(); // crashes when window() == nullptr
}

DPanel::window() is qobject_cast<QQuickWindow*>(rootObject), which returns nullptr whenever the panel's QML root object has not been created yet (still loading/incubating) or failed to load entirely.

Once any QML error prevents the dock root object from being created, the following chain kills the whole shell:

QQmlTimer event
  -> DockPanelPositioner::updatePosition()          (libdock-plugin.so)
  -> DockPositioner::dockGeometry()
  -> QObject::property("geometry") / QMetaProperty::read
  -> DockPanel::geometry()                          (org.deepin.ds.dock.so)
  -> QWindow::geometry()  with this == nullptr      (libQt6Gui)
  => SIGSEGV

Since [email protected] is restarted by systemd after each crash, any dock QML error becomes a crash loop with no desktop at all.

Real-world reproduction (UOS 25 with Qt 6.12, whose QML compiler promotes duplicate property assignments in an object declaration to fatal errors):

Loading url failed "file:///usr/share/dde-shell/org.deepin.ds.dock/main.qml:691:21: Property value set multiple times"
Create root failed: "org.deepin.ds.dock"
Process 2623 (dde-shell) dumped core.  #0 QWindow::geometry() ...

Crash dump analysis: si_addr=0x8, rdi=0 — classic null this + field offset read.

Solution

Return an empty QRect with a qCWarning when the window is not available, so a broken/slow-loading panel degrades gracefully instead of taking down the session. This is consistent with the existing null guards in setFrontendWindowRect() / moveXEmbedWindow() in the same file.

Impact

  • Only touches DockPanel::geometry()
  • No behavior change on the normal path (window exists)

Summary by Sourcery

Bug Fixes:

  • Prevent DockPanel geometry queries from crashing the shell when its QML window is unavailable by returning an empty rectangle and logging a warning.

DockPanel::geometry() unconditionally dereferenced window(), which
returns nullptr whenever the panel's QML root object has not been
created yet (still loading/incubating) or failed to load entirely.

When any QML error prevents the dock main.qml root from being
created, DockPositioner::dockGeometry() -> QMetaProperty::read ->
DockPanel::geometry() dereferences the null window and crashes the
whole dde-shell process. Since dde-shell is session critical, any
dock QML error becomes a crash loop with no desktop at all.

Return an empty QRect with a warning instead, consistent with the
existing null guards in setFrontendWindowRect()/moveXEmbedWindow().

Observed on UOS 25 with Qt 6.12, whose QML compiler promotes
duplicate property assignments to fatal errors:
"Property value set multiple times" -> "Create root failed:
org.deepin.ds.dock" -> SIGSEGV loop in QWindow::geometry().

Signed-off-by: pengfeixx <[email protected]>
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Reviewer's Guide

Implementation

Add a runtime null check to DockPanel::geometry() so an unavailable QML window returns an empty rectangle with a warning instead of crashing.

  • panels/dock/dockpanel.cpp L262-269

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="panels/dock/dockpanel.cpp" line_range="261" />
<code_context>
 QRect DockPanel::geometry()
 {
     Q_ASSERT(window());
+    if (!window()) {
+        // The QML root object may not exist yet, e.g. when the panel QML
</code_context>
<issue_to_address>
**Shell still aborts on missing window**

When `window()` is null in a build with assertions enabled, `Q_ASSERT(window())` aborts before `DockPanel::geometry()` reaches the null guard, so the shell terminates instead of returning an empty rectangle.

Move or remove `Q_ASSERT(window())` so the null guard runs before any assertion on `window()`.

Also at `panels/dock/dockpanel.cpp:262`.
</issue_to_address>

### Comment 2
<location path="panels/dock/dockpanel.cpp" line_range="267" />
<code_context>
+        // failed to load or has not finished incubation. Dereferencing a
+        // null window here crashes the whole shell (SEGV in QWindow::geometry,
+        // triggered from DockPositioner::dockGeometry() via QMetaProperty::read).
+        qCWarning(dockLog) << "DockPanel: window is not available, return empty geometry";
+        return QRect();
+    }
</code_context>
<issue_to_address>
**Repeated queries flood logs**

When the window stays null while timer-driven position updates keep querying geometry, each null-window query emits another warning, so timer-driven `DockPositioner` updates repeatedly fill the logs while the panel remains unavailable.

Rate-limit the warning or log it only once until the window becomes available.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread panels/dock/dockpanel.cpp
@@ -259,6 +259,14 @@ bool DockPanel::init()
QRect DockPanel::geometry()
{
Q_ASSERT(window());

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Shell still aborts on missing window

When window() is null in a build with assertions enabled, Q_ASSERT(window()) aborts before DockPanel::geometry() reaches the null guard, so the shell terminates instead of returning an empty rectangle.

Move or remove Q_ASSERT(window()) so the null guard runs before any assertion on window().

Also at panels/dock/dockpanel.cpp:262.

Prompt for AI agents
In `panels/dock/dockpanel.cpp` at line 261:

**Shell still aborts on missing window**

When `window()` is null in a build with assertions enabled, `Q_ASSERT(window())` aborts before `DockPanel::geometry()` reaches the null guard, so the shell terminates instead of returning an empty rectangle.

Move or remove `Q_ASSERT(window())` so the null guard runs before any assertion on `window()`.

Also at `panels/dock/dockpanel.cpp:262`.

Comment thread panels/dock/dockpanel.cpp
// failed to load or has not finished incubation. Dereferencing a
// null window here crashes the whole shell (SEGV in QWindow::geometry,
// triggered from DockPositioner::dockGeometry() via QMetaProperty::read).
qCWarning(dockLog) << "DockPanel: window is not available, return empty geometry";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Repeated queries flood logs

When the window stays null while timer-driven position updates keep querying geometry, each null-window query emits another warning, so timer-driven DockPositioner updates repeatedly fill the logs while the panel remains unavailable.

Rate-limit the warning or log it only once until the window becomes available.

Prompt for AI agents
In `panels/dock/dockpanel.cpp` at line 267:

**Repeated queries flood logs**

When the window stays null while timer-driven position updates keep querying geometry, each null-window query emits another warning, so timer-driven `DockPositioner` updates repeatedly fill the logs while the panel remains unavailable.

Rate-limit the warning or log it only once until the window becomes available.

@deepin-ci-robot

deepin-ci-robot commented Nov 19, 2026 •

Copy link
Copy Markdown

⚠️ OBS CI 构建警告日志 (Commit: 58e48798)

提示:以下为 OBS CI 构建中 Lintian 检测到的警告信息,默认折叠,点击展开查看详情。完整日志请参阅对应构建状态链接。

deepin_develop / aarch64 (Lintian 警告: 15 条)
[  717s] W: dde-shell: desktop-command-not-in-package bin/false [usr/share/applications/org.deepin.dde-shell.desktop]
[  717s] N: 
[  717s] N:   The desktop entry specifies a Command that does not match any of the
[  717s] N:   executables shipped in the package.
[  717s] N:   
[  717s] N:   This condition is often caused by a typo, or the desktop file was not
[  717s] N:   updated after the installed path of the executable was modified.
[  717s] N:   
[  717s] N:   Packages should ship executables that are used as commands in desktop
[  717s] N:   files.
[  717s] N: 
[  717s] N:   Visibility: warning
[  717s] N:   Show-Always: no
[  717s] N:   Check: menu-format
[  717s] N: 
[  717s] N:
[  717s] W: dde-shell: link-to-shared-library-in-wrong-package usr/lib/aarch64-linux-gnu/libds-notification-shared.so.2.0.61 [usr/lib/aarch64-linux-gnu/libds-notification-shared.so]
[  717s] N: 
[  717s] N:   Although this package is not a "-dev" package, it installs a
[  717s] N:   "libsomething.so" symbolic link referencing the corresponding shared
[  717s] N:   library. When the link doesn't include the version number, it is used by
[  717s] N:   the linker when other programs are built against this shared library.
[  717s] N:   
[  717s] N:   Shared libraries are supposed to place such symbolic links in their
[  717s] N:   respective "-dev" packages, so it is a bug to include it with the main
[  717s] N:   library package.
[  717s] N:   
[  717s] N:   However, if this is a small package which includes the runtime and the
[  717s] N:   development libraries, this is not a bug. In the latter case, please
[  717s] N:   override this warning.
[  717s] N: 
[  717s] N:   Please refer to Development files (Section 8.4) in the Debian Policy
[  717s] N:   Manual for details.
[  717s] N: 
[  717s] N:   Visibility: warning
[  717s] N:   Show-Always: no
[  717s] N:   Check: libraries/shared/links
[  717s] N:   Renamed from: non-dev-pkg-with-shlib-symlink
[  717s] N: 
[  717s] N:
[  717s] W: dde-shell: no-manual-page [usr/bin/dde-shell]
[  717s] N: 
[  717s] N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
[  717s] N:   a manual page
[  717s] N:   
[  717s] N:   Note that though the man program has the capability to check for several
[  717s] N:   program names in the NAMES section, each of these programs should have its
[  717s] N:   own manual page (a symbolic link to the appropriate manual page is
[  717s] N:   sufficient) because other manual page viewers such as xman or tkman don't
[  717s] N:   support this.
[  717s] N:   
[  717s] N:   If the name of the manual page differs from the binary by case, man may be
[  717s] N:   able to find it anyway; however, it is still best practice to match the
[  717s] N:   exact capitalization of the executable in the manual page.
[  717s] N:   
[  717s] N:   If the manual pages are provided by another package on which this package
[  717s] N:   depends, Lintian may not be able to determine that manual pages are
[  717s] N:   available. In this case, after confirming that all binaries do have manual
[  717s] N:   pages after this package and its dependencies are installed, please add a
[  717s] N:   Lintian override.
[  717s] N: 
[  717s] N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
[  717s] N:   for details.
[  717s] N: 
[  717s] N:   Visibility: warning
[  717s] N:   Show-Always: no
[  717s] N:   Check: documentation/manual
[  717s] N:   Renamed from: binary-without-manpage
[  717s] N: 
[  717s] N:
[  717s] W: dde-shell source: no-nmu-in-changelog [debian/changelog:1]
[  717s] N: 
[  717s] N:   When you NMU a package, that fact should be mentioned on the first line in
[  717s] N:   the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case
[  717s] N:   insensitive).
[  717s] N:   
[  717s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  717s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  717s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  717s] N:   package (not intended for Debian), you can suppress this warning by
[  717s] N:   putting "local" in the version number or "local package" on the first line
[  717s] N:   of the changelog entry.
[  717s] N: 
[  717s] N:   Please refer to Using the DELAYED/ queue (Section 5.11.3) in the Debian
[  717s] N:   Developer's Reference for details.
[  717s] N: 
[  717s] N:   Visibility: warning
[  717s] N:   Show-Always: no
[  717s] N:   Check: nmu
[  717s] N:   Renamed from: changelog-should-mention-nmu
[  717s] N: 
[  717s] N:
[  717s] W: dde-shell: package-name-doesnt-match-sonames libds-notification-shared2
[  717s] N: 
[  717s] N:   The package name of a library package should usually reflect the soname of
[  717s] N:   the included library. The package name can determined from the library
[  717s] N:   file name with the following code snippet:
[  717s] N:   
[  717s] N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
[  717s] N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
[  717s] N: 
[  717s] N:   Visibility: warning
[  717s] N:   Show-Always: no
[  717s] N:   Check: libraries/shared/soname
[  717s] N: 
[  717s] N:
[  717s] W: libdde-shell: package-name-doesnt-match-sonames libdde-shell1
[  717s] N:
[  717s] W: libdde-shell-dock: package-name-doesnt-match-sonames libdde-shell-dock1
[  717s] N:
[  717s] W: dde-shell source: source-nmu-has-incorrect-version-number 2.0.61+u029 [debian/changelog:1]
[  717s] N: 
[  717s] N:   A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
[  717s] N:   native package). This is to prevent stealing version numbers from the
[  717s] N:   maintainer.
[  717s] N:   
[  717s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  717s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  717s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  717s] N:   package (not intended for Debian), you can suppress this warning by
[  717s] N:   putting "local" in the version number or "local package" on the first line
[  717s] N:   of the changelog entry.
[  717s] N: 
[  717s] N:   Please refer to NMUs and debian/changelog (Section 5.11.2) in the Debian
[  717s] N:   Developer's Reference for details.
[  717s] N: 
[  717s] N:   Visibility: warning
[  717s] N:   Show-Always: no
[  717s] N:   Check: nmu
[  717s] N: 
[  717s] N:
[  717s] W: dde-shell: unknown-section DDE
[  717s] N: 
[  717s] N:   The "Section:" field in this package's control file is not one of the
[  717s] N:   sections in use on the ftp archive. Valid sections are currently admin,
[  717s] N:   comm, cli-mono, database, debug, devel, doc, editors, electronics,
[  717s] N:   embedded, fonts, games, gnome, gnu-r, gnustep, graphics, hamradio,
[  717s] N:   haskell, httpd, interpreters, java, javascript, kde, libdevel, libs, lisp,
[  717s] N:   localization, kernel, mail, math, misc, net, news, ocaml, oldlibs,
[  717s] N:   otherosfs, perl, php, python, ruby, rust, science, shells, sound, tex,
[  717s] N:   text, utils, vcs, video, web, x11, xfce, zope.
[  717s] N:   
[  717s] N:   The section name should be preceded by either "contrib/", "non-free/" or
[  717s] N:   "non-free-firmware/" if the package is in the according archive area.
[  717s] N: 
[  717s] N:   Please refer to Sections (Section 2.4) in the Debian Policy Manual for
[  717s] N:   details.
[  717s] N: 
[  717s] N:   Visibility: warning
[  717s] N:   Show-Always: no
[  717s] N:   Check: fields/section
[  717s] N: 
[  717s] N:
[  717s] W: dde-shell-example: unknown-section DDE
[  717s] N:
[  717s] W: libdde-shell: unknown-section DDE
[  717s] N:
[  717s] W: libdde-shell-dev: unknown-section DDE
[  717s] N:
[  717s] W: libdde-shell-dock: unknown-section DDE
[  717s] N:
[  717s] W: libdde-shell-dock-dev: unknown-section DDE
[  718s] Warning: mkbaselibs missing in build root, skipping baselibs
deepin_develop / x86_64 (Lintian 警告: 15 条)
[  314s] W: dde-shell: desktop-command-not-in-package bin/false [usr/share/applications/org.deepin.dde-shell.desktop]
[  314s] N: 
[  314s] N:   The desktop entry specifies a Command that does not match any of the
[  314s] N:   executables shipped in the package.
[  314s] N:   
[  314s] N:   This condition is often caused by a typo, or the desktop file was not
[  314s] N:   updated after the installed path of the executable was modified.
[  314s] N:   
[  314s] N:   Packages should ship executables that are used as commands in desktop
[  314s] N:   files.
[  314s] N: 
[  314s] N:   Visibility: warning
[  314s] N:   Show-Always: no
[  314s] N:   Check: menu-format
[  314s] N: 
[  314s] N:
[  314s] W: dde-shell: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-gnu/libds-notification-shared.so.2.0.61 [usr/lib/x86_64-linux-gnu/libds-notification-shared.so]
[  314s] N: 
[  314s] N:   Although this package is not a "-dev" package, it installs a
[  314s] N:   "libsomething.so" symbolic link referencing the corresponding shared
[  314s] N:   library. When the link doesn't include the version number, it is used by
[  314s] N:   the linker when other programs are built against this shared library.
[  314s] N:   
[  314s] N:   Shared libraries are supposed to place such symbolic links in their
[  314s] N:   respective "-dev" packages, so it is a bug to include it with the main
[  314s] N:   library package.
[  314s] N:   
[  314s] N:   However, if this is a small package which includes the runtime and the
[  314s] N:   development libraries, this is not a bug. In the latter case, please
[  314s] N:   override this warning.
[  314s] N: 
[  314s] N:   Please refer to Development files (Section 8.4) in the Debian Policy
[  314s] N:   Manual for details.
[  314s] N: 
[  314s] N:   Visibility: warning
[  314s] N:   Show-Always: no
[  314s] N:   Check: libraries/shared/links
[  314s] N:   Renamed from: non-dev-pkg-with-shlib-symlink
[  314s] N: 
[  314s] N:
[  314s] W: dde-shell: no-manual-page [usr/bin/dde-shell]
[  314s] N: 
[  314s] N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
[  314s] N:   a manual page
[  314s] N:   
[  314s] N:   Note that though the man program has the capability to check for several
[  314s] N:   program names in the NAMES section, each of these programs should have its
[  314s] N:   own manual page (a symbolic link to the appropriate manual page is
[  314s] N:   sufficient) because other manual page viewers such as xman or tkman don't
[  314s] N:   support this.
[  314s] N:   
[  314s] N:   If the name of the manual page differs from the binary by case, man may be
[  314s] N:   able to find it anyway; however, it is still best practice to match the
[  314s] N:   exact capitalization of the executable in the manual page.
[  314s] N:   
[  314s] N:   If the manual pages are provided by another package on which this package
[  314s] N:   depends, Lintian may not be able to determine that manual pages are
[  314s] N:   available. In this case, after confirming that all binaries do have manual
[  314s] N:   pages after this package and its dependencies are installed, please add a
[  314s] N:   Lintian override.
[  314s] N: 
[  314s] N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
[  314s] N:   for details.
[  314s] N: 
[  314s] N:   Visibility: warning
[  314s] N:   Show-Always: no
[  314s] N:   Check: documentation/manual
[  314s] N:   Renamed from: binary-without-manpage
[  314s] N: 
[  314s] N:
[  314s] W: dde-shell source: no-nmu-in-changelog [debian/changelog:1]
[  314s] N: 
[  314s] N:   When you NMU a package, that fact should be mentioned on the first line in
[  314s] N:   the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case
[  314s] N:   insensitive).
[  314s] N:   
[  314s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  314s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  314s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  314s] N:   package (not intended for Debian), you can suppress this warning by
[  314s] N:   putting "local" in the version number or "local package" on the first line
[  314s] N:   of the changelog entry.
[  314s] N: 
[  314s] N:   Please refer to Using the DELAYED/ queue (Section 5.11.3) in the Debian
[  314s] N:   Developer's Reference for details.
[  314s] N: 
[  314s] N:   Visibility: warning
[  314s] N:   Show-Always: no
[  314s] N:   Check: nmu
[  314s] N:   Renamed from: changelog-should-mention-nmu
[  314s] N: 
[  314s] N:
[  314s] W: dde-shell: package-name-doesnt-match-sonames libds-notification-shared2
[  314s] N: 
[  314s] N:   The package name of a library package should usually reflect the soname of
[  314s] N:   the included library. The package name can determined from the library
[  314s] N:   file name with the following code snippet:
[  314s] N:   
[  314s] N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
[  314s] N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
[  314s] N: 
[  314s] N:   Visibility: warning
[  314s] N:   Show-Always: no
[  314s] N:   Check: libraries/shared/soname
[  314s] N: 
[  314s] N:
[  314s] W: libdde-shell: package-name-doesnt-match-sonames libdde-shell1
[  314s] N:
[  314s] W: libdde-shell-dock: package-name-doesnt-match-sonames libdde-shell-dock1
[  314s] N:
[  314s] W: dde-shell source: source-nmu-has-incorrect-version-number 2.0.61+u029 [debian/changelog:1]
[  314s] N: 
[  314s] N:   A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
[  314s] N:   native package). This is to prevent stealing version numbers from the
[  314s] N:   maintainer.
[  314s] N:   
[  314s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  314s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  314s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  314s] N:   package (not intended for Debian), you can suppress this warning by
[  314s] N:   putting "local" in the version number or "local package" on the first line
[  314s] N:   of the changelog entry.
[  314s] N: 
[  314s] N:   Please refer to NMUs and debian/changelog (Section 5.11.2) in the Debian
[  314s] N:   Developer's Reference for details.
[  314s] N: 
[  314s] N:   Visibility: warning
[  314s] N:   Show-Always: no
[  314s] N:   Check: nmu
[  314s] N: 
[  314s] N:
[  314s] W: dde-shell: unknown-section DDE
[  314s] N: 
[  314s] N:   The "Section:" field in this package's control file is not one of the
[  314s] N:   sections in use on the ftp archive. Valid sections are currently admin,
[  314s] N:   comm, cli-mono, database, debug, devel, doc, editors, electronics,
[  314s] N:   embedded, fonts, games, gnome, gnu-r, gnustep, graphics, hamradio,
[  314s] N:   haskell, httpd, interpreters, java, javascript, kde, libdevel, libs, lisp,
[  314s] N:   localization, kernel, mail, math, misc, net, news, ocaml, oldlibs,
[  314s] N:   otherosfs, perl, php, python, ruby, rust, science, shells, sound, tex,
[  314s] N:   text, utils, vcs, video, web, x11, xfce, zope.
[  314s] N:   
[  314s] N:   The section name should be preceded by either "contrib/", "non-free/" or
[  314s] N:   "non-free-firmware/" if the package is in the according archive area.
[  314s] N: 
[  314s] N:   Please refer to Sections (Section 2.4) in the Debian Policy Manual for
[  314s] N:   details.
[  314s] N: 
[  314s] N:   Visibility: warning
[  314s] N:   Show-Always: no
[  314s] N:   Check: fields/section
[  314s] N: 
[  314s] N:
[  314s] W: dde-shell-example: unknown-section DDE
[  314s] N:
[  314s] W: libdde-shell: unknown-section DDE
[  314s] N:
[  314s] W: libdde-shell-dev: unknown-section DDE
[  314s] N:
[  314s] W: libdde-shell-dock: unknown-section DDE
[  314s] N:
[  314s] W: libdde-shell-dock-dev: unknown-section DDE
[  314s] Warning: mkbaselibs missing in build root, skipping baselibs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants