Skip to content

[2500u3] fix(dock): enable smooth icon scaling only when scaled - #1835

Merged
MyLeeJiEun merged 1 commit into
linuxdeepin:develop/2500u3from
wjyrich:backport-pr-1822-2500u3
Nov 19, 2026
Merged

MyLeeJiEun merged 1 commit into
linuxdeepin:develop/2500u3from
wjyrich:backport-pr-1822-2500u3

Conversation

@wjyrich

@wjyrich wjyrich commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Backport #1822 to develop/2500u3 to enable smooth dock icon rendering while the attention animation is active.

Bind DciIcon.smooth to animationRoot.active instead of the constant false, improving icon quality during the scaling animation and preserving sharp icons when the animation is inactive.

Source commit: 7da3398f2f0453760ac5177f97e41f5b25383fa1.
The cherry-picked patch has the same stable patch ID as the source commit.

Validation

  • git diff --check upstream/develop/2500u3...HEAD: passed.
  • Qt 6 qmlformat parsing of AppItem.qml: passed.
  • Confirmed that the target branch provides animationRoot.active.
  • Manual dock animation rendering verification remains to be performed.

中文说明

将 #1822 的最新提交移植到 develop/2500u3,把图标的 smooth 从 false 改为 animationRoot.active,在提醒动画启用时开启平滑渲染,提升缩放动画中的图标质量。

无冲突移植,补丁与原提交一致;QML 语法和空白检查均通过,实际动画渲染效果仍需手动验证。

PMS: BUG-383565

Summary by Sourcery

Bug Fixes:

  • Enable smooth dock icon rendering while the attention scaling animation is active, while keeping inactive icons sharp.

1. Change smooth property from false to  animationRoot.active for app icons
2. Enables smooth rendering when icon is scaled, keeps crisp rendering
at normal size
3. Improves icon visual quality during scaling in the dock task manager

Log: Enable smooth icon scaling conditionally based on scale factor
Influence: Dock icons render more smoothly when scaled.

fix(dock): 仅在缩放时启用图标平滑处理

1. 将应用图标的 smooth 属性由 false 修改 为  animationRoot.active
2. 缩放时启用平滑渲染,正常尺寸下保持清晰渲染
3. 提升任务栏中图标缩放时的视觉质量

Log: 根据缩放比例条件启用图标平滑处理
Influence: 任务栏图标缩放时渲染更平滑。
PMS: BUG-383565
(cherry picked from commit 7da3398)
@sourcery-ai

sourcery-ai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Reviewer's Guide

UI

Bind the dock icon’s smoothing to the animation state so scaling is smooth while inactive icons remain sharp.

  • panels/dock/taskmanager/package/AppItem.qml L202

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

deepin-ci-robot commented Nov 19, 2026 •

Copy link
Copy Markdown

⚠️ OBS CI 构建警告日志 (Commit: 70d025af)

提示:以下为 OBS CI 构建中 Lintian 检测到的警告信息,默认折叠,点击展开查看详情。完整日志请参阅对应构建状态链接。

deepin_develop / aarch64 (Lintian 警告: 15 条)
[  552s] W: dde-shell: desktop-command-not-in-package bin/false [usr/share/applications/org.deepin.dde-shell.desktop]
[  552s] N: 
[  552s] N:   The desktop entry specifies a Command that does not match any of the
[  552s] N:   executables shipped in the package.
[  552s] N:   
[  552s] N:   This condition is often caused by a typo, or the desktop file was not
[  552s] N:   updated after the installed path of the executable was modified.
[  552s] N:   
[  552s] N:   Packages should ship executables that are used as commands in desktop
[  552s] N:   files.
[  552s] N: 
[  552s] N:   Visibility: warning
[  552s] N:   Show-Always: no
[  552s] N:   Check: menu-format
[  552s] N: 
[  552s] N:
[  552s] W: dde-shell: link-to-shared-library-in-wrong-package usr/lib/aarch64-linux-gnu/libds-notification-shared.so.6.2.0 [usr/lib/aarch64-linux-gnu/libds-notification-shared.so]
[  552s] N: 
[  552s] N:   Although this package is not a "-dev" package, it installs a
[  552s] N:   "libsomething.so" symbolic link referencing the corresponding shared
[  552s] N:   library. When the link doesn't include the version number, it is used by
[  552s] N:   the linker when other programs are built against this shared library.
[  552s] N:   
[  552s] N:   Shared libraries are supposed to place such symbolic links in their
[  552s] N:   respective "-dev" packages, so it is a bug to include it with the main
[  552s] N:   library package.
[  552s] N:   
[  552s] N:   However, if this is a small package which includes the runtime and the
[  552s] N:   development libraries, this is not a bug. In the latter case, please
[  552s] N:   override this warning.
[  552s] N: 
[  552s] N:   Please refer to Development files (Section 8.4) in the Debian Policy
[  552s] N:   Manual for details.
[  552s] N: 
[  552s] N:   Visibility: warning
[  552s] N:   Show-Always: no
[  552s] N:   Check: libraries/shared/links
[  552s] N:   Renamed from: non-dev-pkg-with-shlib-symlink
[  552s] N: 
[  552s] N:
[  552s] W: dde-shell: no-manual-page [usr/bin/dde-shell]
[  552s] N: 
[  552s] N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
[  552s] N:   a manual page
[  552s] N:   
[  552s] N:   Note that though the man program has the capability to check for several
[  552s] N:   program names in the NAMES section, each of these programs should have its
[  552s] N:   own manual page (a symbolic link to the appropriate manual page is
[  552s] N:   sufficient) because other manual page viewers such as xman or tkman don't
[  552s] N:   support this.
[  552s] N:   
[  552s] N:   If the name of the manual page differs from the binary by case, man may be
[  552s] N:   able to find it anyway; however, it is still best practice to match the
[  552s] N:   exact capitalization of the executable in the manual page.
[  552s] N:   
[  552s] N:   If the manual pages are provided by another package on which this package
[  552s] N:   depends, Lintian may not be able to determine that manual pages are
[  552s] N:   available. In this case, after confirming that all binaries do have manual
[  552s] N:   pages after this package and its dependencies are installed, please add a
[  552s] N:   Lintian override.
[  552s] N: 
[  552s] N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
[  552s] N:   for details.
[  552s] N: 
[  552s] N:   Visibility: warning
[  552s] N:   Show-Always: no
[  552s] N:   Check: documentation/manual
[  552s] N:   Renamed from: binary-without-manpage
[  552s] N: 
[  552s] N:
[  552s] W: dde-shell source: no-nmu-in-changelog [debian/changelog:1]
[  552s] N: 
[  552s] N:   When you NMU a package, that fact should be mentioned on the first line in
[  552s] N:   the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case
[  552s] N:   insensitive).
[  552s] N:   
[  552s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  552s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  552s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  552s] N:   package (not intended for Debian), you can suppress this warning by
[  552s] N:   putting "local" in the version number or "local package" on the first line
[  552s] N:   of the changelog entry.
[  552s] N: 
[  552s] N:   Please refer to Using the DELAYED/ queue (Section 5.11.3) in the Debian
[  552s] N:   Developer's Reference for details.
[  552s] N: 
[  552s] N:   Visibility: warning
[  552s] N:   Show-Always: no
[  552s] N:   Check: nmu
[  552s] N:   Renamed from: changelog-should-mention-nmu
[  552s] N: 
[  552s] N:
[  552s] W: dde-shell: package-name-doesnt-match-sonames libds-notification-shared6
[  552s] N: 
[  552s] N:   The package name of a library package should usually reflect the soname of
[  552s] N:   the included library. The package name can determined from the library
[  552s] N:   file name with the following code snippet:
[  552s] N:   
[  552s] N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
[  552s] N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
[  552s] N: 
[  552s] N:   Visibility: warning
[  552s] N:   Show-Always: no
[  552s] N:   Check: libraries/shared/soname
[  552s] N: 
[  552s] N:
[  552s] W: libdde-shell: package-name-doesnt-match-sonames libdde-shell1
[  552s] N:
[  552s] W: libdde-shell-dock: package-name-doesnt-match-sonames libdde-shell-dock1
[  552s] N:
[  552s] W: dde-shell source: source-nmu-has-incorrect-version-number 6.2.0+u004 [debian/changelog:1]
[  552s] N: 
[  552s] N:   A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
[  552s] N:   native package). This is to prevent stealing version numbers from the
[  552s] N:   maintainer.
[  552s] N:   
[  552s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  552s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  552s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  552s] N:   package (not intended for Debian), you can suppress this warning by
[  552s] N:   putting "local" in the version number or "local package" on the first line
[  552s] N:   of the changelog entry.
[  552s] N: 
[  552s] N:   Please refer to NMUs and debian/changelog (Section 5.11.2) in the Debian
[  552s] N:   Developer's Reference for details.
[  552s] N: 
[  552s] N:   Visibility: warning
[  552s] N:   Show-Always: no
[  552s] N:   Check: nmu
[  552s] N: 
[  552s] N:
[  552s] W: dde-shell: unknown-section DDE
[  552s] N: 
[  552s] N:   The "Section:" field in this package's control file is not one of the
[  552s] N:   sections in use on the ftp archive. Valid sections are currently admin,
[  552s] N:   comm, cli-mono, database, debug, devel, doc, editors, electronics,
[  552s] N:   embedded, fonts, games, gnome, gnu-r, gnustep, graphics, hamradio,
[  552s] N:   haskell, httpd, interpreters, java, javascript, kde, libdevel, libs, lisp,
[  552s] N:   localization, kernel, mail, math, misc, net, news, ocaml, oldlibs,
[  552s] N:   otherosfs, perl, php, python, ruby, rust, science, shells, sound, tex,
[  552s] N:   text, utils, vcs, video, web, x11, xfce, zope.
[  552s] N:   
[  552s] N:   The section name should be preceded by either "contrib/", "non-free/" or
[  552s] N:   "non-free-firmware/" if the package is in the according archive area.
[  552s] N: 
[  552s] N:   Please refer to Sections (Section 2.4) in the Debian Policy Manual for
[  552s] N:   details.
[  552s] N: 
[  552s] N:   Visibility: warning
[  552s] N:   Show-Always: no
[  552s] N:   Check: fields/section
[  552s] N: 
[  552s] N:
[  552s] W: dde-shell-example: unknown-section DDE
[  552s] N:
[  552s] W: libdde-shell: unknown-section DDE
[  552s] N:
[  552s] W: libdde-shell-dev: unknown-section DDE
[  552s] N:
[  552s] W: libdde-shell-dock: unknown-section DDE
[  552s] N:
[  552s] W: libdde-shell-dock-dev: unknown-section DDE
[  553s] Warning: mkbaselibs missing in build root, skipping baselibs
deepin_develop / x86_64 (Lintian 警告: 15 条)
[  332s] W: dde-shell: desktop-command-not-in-package bin/false [usr/share/applications/org.deepin.dde-shell.desktop]
[  332s] N: 
[  332s] N:   The desktop entry specifies a Command that does not match any of the
[  332s] N:   executables shipped in the package.
[  332s] N:   
[  332s] N:   This condition is often caused by a typo, or the desktop file was not
[  332s] N:   updated after the installed path of the executable was modified.
[  332s] N:   
[  332s] N:   Packages should ship executables that are used as commands in desktop
[  332s] N:   files.
[  332s] N: 
[  332s] N:   Visibility: warning
[  332s] N:   Show-Always: no
[  332s] N:   Check: menu-format
[  332s] N: 
[  332s] N:
[  332s] W: dde-shell: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-gnu/libds-notification-shared.so.6.2.0 [usr/lib/x86_64-linux-gnu/libds-notification-shared.so]
[  332s] N: 
[  332s] N:   Although this package is not a "-dev" package, it installs a
[  332s] N:   "libsomething.so" symbolic link referencing the corresponding shared
[  332s] N:   library. When the link doesn't include the version number, it is used by
[  332s] N:   the linker when other programs are built against this shared library.
[  332s] N:   
[  332s] N:   Shared libraries are supposed to place such symbolic links in their
[  332s] N:   respective "-dev" packages, so it is a bug to include it with the main
[  332s] N:   library package.
[  332s] N:   
[  332s] N:   However, if this is a small package which includes the runtime and the
[  332s] N:   development libraries, this is not a bug. In the latter case, please
[  332s] N:   override this warning.
[  332s] N: 
[  332s] N:   Please refer to Development files (Section 8.4) in the Debian Policy
[  332s] N:   Manual for details.
[  332s] N: 
[  332s] N:   Visibility: warning
[  332s] N:   Show-Always: no
[  332s] N:   Check: libraries/shared/links
[  332s] N:   Renamed from: non-dev-pkg-with-shlib-symlink
[  332s] N: 
[  332s] N:
[  332s] W: dde-shell: no-manual-page [usr/bin/dde-shell]
[  332s] N: 
[  332s] N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
[  332s] N:   a manual page
[  332s] N:   
[  332s] N:   Note that though the man program has the capability to check for several
[  332s] N:   program names in the NAMES section, each of these programs should have its
[  332s] N:   own manual page (a symbolic link to the appropriate manual page is
[  332s] N:   sufficient) because other manual page viewers such as xman or tkman don't
[  332s] N:   support this.
[  332s] N:   
[  332s] N:   If the name of the manual page differs from the binary by case, man may be
[  332s] N:   able to find it anyway; however, it is still best practice to match the
[  332s] N:   exact capitalization of the executable in the manual page.
[  332s] N:   
[  332s] N:   If the manual pages are provided by another package on which this package
[  332s] N:   depends, Lintian may not be able to determine that manual pages are
[  332s] N:   available. In this case, after confirming that all binaries do have manual
[  332s] N:   pages after this package and its dependencies are installed, please add a
[  332s] N:   Lintian override.
[  332s] N: 
[  332s] N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
[  332s] N:   for details.
[  332s] N: 
[  332s] N:   Visibility: warning
[  332s] N:   Show-Always: no
[  332s] N:   Check: documentation/manual
[  332s] N:   Renamed from: binary-without-manpage
[  332s] N: 
[  332s] N:
[  332s] W: dde-shell source: no-nmu-in-changelog [debian/changelog:1]
[  332s] N: 
[  332s] N:   When you NMU a package, that fact should be mentioned on the first line in
[  332s] N:   the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case
[  332s] N:   insensitive).
[  332s] N:   
[  332s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  332s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  332s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  332s] N:   package (not intended for Debian), you can suppress this warning by
[  332s] N:   putting "local" in the version number or "local package" on the first line
[  332s] N:   of the changelog entry.
[  332s] N: 
[  332s] N:   Please refer to Using the DELAYED/ queue (Section 5.11.3) in the Debian
[  332s] N:   Developer's Reference for details.
[  332s] N: 
[  332s] N:   Visibility: warning
[  332s] N:   Show-Always: no
[  332s] N:   Check: nmu
[  332s] N:   Renamed from: changelog-should-mention-nmu
[  332s] N: 
[  332s] N:
[  332s] W: dde-shell: package-name-doesnt-match-sonames libds-notification-shared6
[  332s] N: 
[  332s] N:   The package name of a library package should usually reflect the soname of
[  332s] N:   the included library. The package name can determined from the library
[  332s] N:   file name with the following code snippet:
[  332s] N:   
[  332s] N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
[  332s] N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
[  332s] N: 
[  332s] N:   Visibility: warning
[  332s] N:   Show-Always: no
[  332s] N:   Check: libraries/shared/soname
[  332s] N: 
[  332s] N:
[  332s] W: libdde-shell: package-name-doesnt-match-sonames libdde-shell1
[  332s] N:
[  332s] W: libdde-shell-dock: package-name-doesnt-match-sonames libdde-shell-dock1
[  332s] N:
[  332s] W: dde-shell source: source-nmu-has-incorrect-version-number 6.2.0+u004 [debian/changelog:1]
[  332s] N: 
[  332s] N:   A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
[  332s] N:   native package). This is to prevent stealing version numbers from the
[  332s] N:   maintainer.
[  332s] N:   
[  332s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  332s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  332s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  332s] N:   package (not intended for Debian), you can suppress this warning by
[  332s] N:   putting "local" in the version number or "local package" on the first line
[  332s] N:   of the changelog entry.
[  332s] N: 
[  332s] N:   Please refer to NMUs and debian/changelog (Section 5.11.2) in the Debian
[  332s] N:   Developer's Reference for details.
[  332s] N: 
[  332s] N:   Visibility: warning
[  332s] N:   Show-Always: no
[  332s] N:   Check: nmu
[  332s] N: 
[  332s] N:
[  332s] W: dde-shell: unknown-section DDE
[  332s] N: 
[  332s] N:   The "Section:" field in this package's control file is not one of the
[  332s] N:   sections in use on the ftp archive. Valid sections are currently admin,
[  332s] N:   comm, cli-mono, database, debug, devel, doc, editors, electronics,
[  332s] N:   embedded, fonts, games, gnome, gnu-r, gnustep, graphics, hamradio,
[  332s] N:   haskell, httpd, interpreters, java, javascript, kde, libdevel, libs, lisp,
[  332s] N:   localization, kernel, mail, math, misc, net, news, ocaml, oldlibs,
[  332s] N:   otherosfs, perl, php, python, ruby, rust, science, shells, sound, tex,
[  332s] N:   text, utils, vcs, video, web, x11, xfce, zope.
[  332s] N:   
[  332s] N:   The section name should be preceded by either "contrib/", "non-free/" or
[  332s] N:   "non-free-firmware/" if the package is in the according archive area.
[  332s] N: 
[  332s] N:   Please refer to Sections (Section 2.4) in the Debian Policy Manual for
[  332s] N:   details.
[  332s] N: 
[  332s] N:   Visibility: warning
[  332s] N:   Show-Always: no
[  332s] N:   Check: fields/section
[  332s] N: 
[  332s] N:
[  332s] W: dde-shell-example: unknown-section DDE
[  332s] N:
[  332s] W: libdde-shell: unknown-section DDE
[  332s] N:
[  332s] W: libdde-shell-dev: unknown-section DDE
[  332s] N:
[  332s] W: libdde-shell-dock: unknown-section DDE
[  332s] N:
[  332s] W: libdde-shell-dock-dev: unknown-section DDE
[  333s] Warning: mkbaselibs missing in build root, skipping baselibs

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MyLeeJiEun, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MyLeeJiEun
MyLeeJiEun merged commit da131fd into linuxdeepin:develop/2500u3 Nov 19, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants