Repository navigation
Conversation
|
Thanks for opening this pull request! Be sure to follow the pull request template! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance: OpenAI Codex via DeepSeek Harness was used for investigation, implementation, review, and testing.
Description:
Upgrade all installed
php85*packages, including inherited PHP-FPM and extension packages, and require PHP CLI and FPM version 8.5.13 or later.Add build-time checks for the PHP version and the required SimpleXML, Memcached, and PDO MySQL extensions.
Apply the same changes to
DockerfileandDockerfile.aarch64.Add timeouts and HTTP error handling to the Codeberg source archive download. If it fails, download the same release tag from the official BookStack GitHub mirror. For the tested
v26.09.3release, both hosts resolve to commitbf680915b6dbaf93eee5234ec72dc33bc5abafbf.The BookStack release selection, base image, entrypoint, and
/configlayout remain unchanged. Documentation and the changelog are updated inreadme-vars.yml; generated files are not edited.Benefits of this PR and context:
The base image used during validation contained PHP 8.5.12. Rebuilding BookStack against that base alone did not include the PHP security fixes released on 19 November 2026.
Upgrading inherited PHP packages is necessary: installing only the application's explicitly listed dependencies does not reliably update the existing CLI, FPM, Session, SimpleXML, and other runtime packages.
Critical PHP vulnerabilities addressed
PHP 8.5.13 also includes fixes for:
PATH_INFOcorrection.The update also resolves the SimpleXML garbage-collection double-free regression, GH-24488.
Exploitability depends on the configuration, SAPI, and application code. This list does not imply that every listed issue is reachable in a default BookStack installation.
For CVE-2026-115560, existing configuration overrides still require review. If session upload progress is explicitly enabled, all applications sharing its session storage must use consistent session serializers.
How Has This Been Tested?
Tested locally with Docker Engine 29.9.1 and Buildx 0.39.1.
--no-cache --pull.SIMPLEXML_TEST_OK./configvolume./config, then verified that the book and configuration persisted./config, verified login and the existing book, and repeated the restart/persistence check.No production data or credentials were used. OIDC integration and migration of an existing production database were not tested.
Source / References: