Repository navigation
T-22643 [CI] Configure AWS credentials before the ZIP step so the cleanup can always run - #19
Merged
Merged
Conversation
…can always run The cleanup step runs always, but the credentials step came after the ZIP step: when the ZIP download failed, every aws call in the cleanup ended in NoCredentials, leftovers of earlier runs stayed in the account and the job reported a second failing step. The credentials now come right after the checkout. Co-Authored-By: Claude Fable 5.1 <[email protected]>
PetrHeinz
marked this pull request as ready for review
November 9, 2026 09:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup step runs
always(), but the AWS credentials step came after the step that downloads or builds the Lambda ZIP. When that step fails (on 2026-11-08 GitHub answered the latest-release download with HTTP 504), the cleanup has no credentials: everyawscall ends inNoCredentials, the stale Lambdas and log groups of earlier runs stay in the account, and the job reports a second failing step for what is one failure.The credentials step now comes right after the checkout, before anything that can fail, so the cleanup can always delete this run's and stale resources.
🤖 Generated with Claude Code