Skip to content

T-22643 [CI] Configure AWS credentials before the ZIP step so the cleanup can always run - #19

Merged
PetrHeinz merged 1 commit into
mainfrom
claude/t-22643-credentials-before-zip
Nov 9, 2026
Merged

PetrHeinz merged 1 commit into
mainfrom
claude/t-22643-credentials-before-zip

Conversation

@PetrHeinz

Copy link
Copy Markdown
Member

The cleanup step runs always(), but the AWS credentials step came after the step that downloads or builds the Lambda ZIP. When that step fails (on 2026-11-08 GitHub answered the latest-release download with HTTP 504), the cleanup has no credentials: every aws call ends in NoCredentials, the stale Lambdas and log groups of earlier runs stay in the account, and the job reports a second failing step for what is one failure.

The credentials step now comes right after the checkout, before anything that can fail, so the cleanup can always delete this run's and stale resources.

🤖 Generated with Claude Code

…can always run

The cleanup step runs always, but the credentials step came after the
ZIP step: when the ZIP download failed, every aws call in the cleanup
ended in NoCredentials, leftovers of earlier runs stayed in the account
and the job reported a second failing step. The credentials now come
right after the checkout.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
@PetrHeinz PetrHeinz changed the title T-22643 Configure AWS credentials before the ZIP step so the cleanup can always run T-22643 [CI] Configure AWS credentials before the ZIP step so the cleanup can always run Nov 9, 2026
@PetrHeinz
PetrHeinz marked this pull request as ready for review November 9, 2026 09:58
@PetrHeinz
PetrHeinz merged commit 3ff6a3f into main Nov 9, 2026
5 checks passed
@PetrHeinz
PetrHeinz deleted the claude/t-22643-credentials-before-zip branch November 9, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant