Repository navigation
openkal-kit 0.3.1: a port is formatted with all its digits - #65
Merged
Merged
Conversation
format_v4 wrote at most three digits of each number, which is every digit of an octet and not of a port: port 8080 came out as "127.0.0.1:080". Each number is now written whole; the octets are written as before. The kit's test formats ports 0, 80, 8080 and 65535 and reads each back. The kit's Linux dev-dependency names openkal-linux 0.26.0, the implementation of openkal 0.25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kal::kit::format_v4wrote at most three digits of each number. That is every digit of an octet but not of a port: port 8080 came out as127.0.0.1:080. Each number is now written whole, and the octets are written as before. The 22-character bound already allowed for255.255.255.255:65535.The specification is unchanged; only the kit package (tag
kit-0.3.1) is released.Test plan
tools/run-kit-tests.sh openkal-linux, gcc and llvm:kit ... ok) and the rest of the suite.