Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
r0b1n
force-pushed
the
r0b1n/marketplace-publish-api
branch
from
November 20, 2026 10:33
4b8b16d to
54138b3
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
previously approved these changes
Nov 20, 2026
iobuhov
previously approved these changes
Nov 20, 2026
Replace the Contributor API's GitHub integration with the Marketplace Publish API. The publish script now creates a draft release, uploads the MPK from the GitHub release itself and publishes it explicitly. - Release notes come from the GitHub release body, converted from markdown to simple HTML. Headings start at h4 because the Marketplace page renders the release title as h3. `release-notes-html <tag|file>` previews the output. - A draft is deleted when the upload or publish fails or the job is cancelled. The API can't list releases, so a lost draft would block its version until it is removed in the Marketplace UI. The draft id is written to the job summary as soon as it exists. - A 409 on create explains how to remove a leftover draft. - Warn when the Marketplace component name differs from marketplace.appName, since the Publish API can't rename components. - Auth is a single MX_PAT (secret MARKETPLACE_PAT) instead of the CPAPI_* credentials.
r0b1n
force-pushed
the
r0b1n/marketplace-publish-api
branch
from
November 20, 2026 14:46
54138b3 to
0edd6b6
Compare
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): CI: pending: Run code quality check, Plan E2E matrix, sigridci, code/snyk · unrelated failure: security/snyk (external scanner; not traced to this diff) Questions
Positives
|
iobuhov
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Why
Marketplace is moving from the Contributor API's GitHub integration to the Publish API. Instead of pointing the Marketplace at a GitHub release asset, we now supply the release data and upload the MPK ourselves.
What changed
rui-publish-marketplacecreates a draft (publishManually: true), uploads the MPK taken from the GitHub release (with READMEOSS already embedded), then publishes explicitly. Client:src/api/marketplace-publish.ts.releaseNotesToHtml(src/release-notes-html.ts). Headings start at h4 because the Marketplace page renders the release title as h3; raw HTML is escaped. The options are kept in one place so we can tune the output. Preview:pnpm --filter @mendix/automation-utils run release-notes-html <tag|file.md>.marketplace.appName.release-widgetskill: release-notes note in Phase 6, new failure handling in Phase 7, unpublish via API in Phase 8.Scope
automation/utils,PublishMarketplace.yml,turbo.json,release-widgetskill. No widget or shared package changes, so no changelog. Addsmarkdown-it(already used bymarkdown-web) toautomation/utils; pnpm also dropped one stale peer-variant snapshot ofpluggable-widgets-toolsfrom the lockfile.Tradeoffs
Name: appName, which renamed the listing; renames now have to be done in the Marketplace UI (hence the warning). React-ready lives on the component.CHANGELOG.md, so edits to the draft release are what gets published, as before.Blast radius
None outside the release automation.
fetch.tsloses its Marketplace-specific 409 hint; its remaining callers are GitHub API calls, which now get the generic error for a 409.contributor.tshad no other callers.Verification
automation/utils:tsc, lint (no new warnings) andpnpm run test(30/30) pass. The cancel test runs a child process, sends SIGTERM during the upload, and checks the draft is deleted and the exit code is 143.Publishedimmediately; two drafts of different versions can coexist; creating an existing version (even a draft) → 409.Widget package version does not match the Release version number), draft deleted, rerun of the same version succeeded.rel="nofollow"to links.MARKETPLACE_PAT, and whether a CI cancel signal reachesnodethroughpnpmandturbo. The job summary's release id is the fallback if it doesn't.