Skip to content

fix(automation): declare typescript in automation-utils so the release dashboard can install - #2548

Merged
r0b1n merged 4 commits into
mainfrom
r0b1n/release-dashboard-install
Nov 20, 2026
Merged

r0b1n merged 4 commits into
mainfrom
r0b1n/release-dashboard-install

Conversation

@r0b1n

@r0b1n r0b1n commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Pull request type

Dependency changes (any modification to dependencies in package.json)


Why

The first run of the release dashboard workflow after #2543 was merged failed at Install dependencies: https://github.com/mendix/web-widgets/actions/runs/44718640852

The workflow installs only @mendix/automation-utils. That package's prepare script runs tsc, but typescript isn't declared in its package.json. It works in full installs only because shamefully-hoist puts TypeScript from other packages on the shared .bin path. A filtered install doesn't, so it fails with tsc: not found.

What changed

  • @mendix/automation-utils declares typescript as a devDependency with range *. The root pnpm.overrides entry (>5.8.0 <6.0.0) decides the version, so it resolves to the same 5.9.3 used across the repo.
  • The type check moved from prepare to lint (tsc && eslint . package.json), the same way packages/shared/charts does it. The package's tsconfig is noEmit, so prepare built nothing. It only type-checked on every pnpm install in the repo. Type errors are now caught when lint runs.
  • The workflow uses a plain filtered install again. The --ignore-scripts workaround from the first commit is reverted.
  • AGENTS.md: the constraint on lockfiles and generated files now forbids editing them by hand, not changes made by their tools (for example pnpm add updating pnpm-lock.yaml). The old wording ruled out any dependency change.

Scope

automation/utils, ReleaseDashboard.yml, AGENTS.md, and the matching pnpm-lock.yaml importer entry (an 8-line diff).

Left out: automation/utils also relies on hoisting for eslint, so pnpm run lint fails after a filtered install. The workflow doesn't run lint, and full installs have eslint. Declaring it belongs with a broader cleanup of undeclared tool dependencies.

Blast radius

None outside automation. Installs no longer run a type check for automation-utils, and lint does it instead. pnpm install --frozen-lockfile passes. rui-release-status.ts became executable (100755), like every other bin in that folder.

Verification

On a clean copy of this branch:

  • pnpm install --frozen-lockfile --filter @mendix/automation-utils succeeds and provides tsc.
  • tsc passes, and all 31 automation-utils tests pass.

In the worktree, pnpm run lint (type check plus eslint) passes.

@r0b1n
r0b1n requested a review from a team as a code owner November 20, 2026 10:33
@github-actions

This comment has been minimized.

@r0b1n r0b1n changed the title fix(automation): skip install scripts in release dashboard workflow fix(automation): declare typescript in automation-utils so the release dashboard can install Nov 20, 2026
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
automation/utils/package.json Adds typescript as a devDependency and moves tsc from prepare to lint
automation/utils/bin/rui-release-status.ts File mode changed to 100755
AGENTS.md The constraint now forbids hand-editing lockfiles and generated files, and allows changes their tools make

Skipped (out of scope): pnpm-lock.yaml. I checked it only against the package.json change. The importer entry resolves to 5.9.3, as the PR describes.

CI: pending: sigridci · unrelated failures: security/snyk (external scanner)


Positives

  • The fix addresses the root cause. A filtered install no longer depends on shamefully-hoist to provide tsc.
  • The tsconfig is noEmit, so dropping prepare loses no build output. Type checking now runs in lint, like packages/shared/charts.
  • The PR description is thorough: it covers why, scope, blast radius and verification.

@r0b1n
r0b1n enabled auto-merge November 20, 2026 12:14
@r0b1n
r0b1n merged commit 4d7dc0f into main Nov 20, 2026
20 of 21 checks passed
@r0b1n
r0b1n deleted the r0b1n/release-dashboard-install branch November 20, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants