Repository navigation
fix(automation): declare typescript in automation-utils so the release dashboard can install - #2548
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
…k in lint instead of prepare
This comment has been minimized.
This comment has been minimized.
Contributor
AI Code Review
What was reviewed
Skipped (out of scope): CI: pending: sigridci · unrelated failures: security/snyk (external scanner) Positives
|
iobuhov
approved these changes
Nov 20, 2026
r0b1n
enabled auto-merge
November 20, 2026 12:14
yordan-st
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Dependency changes (any modification to dependencies in
package.json)Why
The first run of the release dashboard workflow after #2543 was merged failed at
Install dependencies: https://github.com/mendix/web-widgets/actions/runs/44718640852The workflow installs only
@mendix/automation-utils. That package'spreparescript runstsc, buttypescriptisn't declared in itspackage.json. It works in full installs only becauseshamefully-hoistputs TypeScript from other packages on the shared.binpath. A filtered install doesn't, so it fails withtsc: not found.What changed
@mendix/automation-utilsdeclarestypescriptas a devDependency with range*. The rootpnpm.overridesentry (>5.8.0 <6.0.0) decides the version, so it resolves to the same 5.9.3 used across the repo.preparetolint(tsc && eslint . package.json), the same waypackages/shared/chartsdoes it. The package's tsconfig isnoEmit, sopreparebuilt nothing. It only type-checked on everypnpm installin the repo. Type errors are now caught when lint runs.--ignore-scriptsworkaround from the first commit is reverted.pnpm addupdatingpnpm-lock.yaml). The old wording ruled out any dependency change.Scope
automation/utils,ReleaseDashboard.yml,AGENTS.md, and the matchingpnpm-lock.yamlimporter entry (an 8-line diff).Left out:
automation/utilsalso relies on hoisting foreslint, sopnpm run lintfails after a filtered install. The workflow doesn't run lint, and full installs have eslint. Declaring it belongs with a broader cleanup of undeclared tool dependencies.Blast radius
None outside automation. Installs no longer run a type check for automation-utils, and lint does it instead.
pnpm install --frozen-lockfilepasses.rui-release-status.tsbecame executable (100755), like every other bin in that folder.Verification
On a clean copy of this branch:
pnpm install --frozen-lockfile --filter @mendix/automation-utilssucceeds and providestsc.tscpasses, and all 31 automation-utils tests pass.In the worktree,
pnpm run lint(type check plus eslint) passes.