Repository navigation
test: add unit tests for connectors validation functions of microcks_client.go - #289
Closed
patilpratik1905 wants to merge 1 commit into
Closed
patilpratik1905 wants to merge 1 commit into
patilpratik1905 wants to merge 1 commit into
Conversation
…client.go Signed-off-by: Pratik Patil <[email protected]>
patilpratik1905
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
May 5, 2026 12:27
Member
|
@patilpratik1905 Since this PR was opened, these functions have changed on master: they now return errors rather than booleans, and |
Member
|
Closing because these tests target outdated function names and signatures and no longer compile against master. A refreshed test PR is welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem :
The pkg/connectors package had no test coverage for critical validation functions:
These functions act as gatekeepers for validating JSON inputs before sending data to Microcks APIs. Without tests, malformed inputs could go undetected.
Solution :
Added 33 table-driven unit tests in:
New file:
pkg/connectors/microcks_client_test.goTestEnsureValidOperationsList (10 tests)
TestEnsureValidOperationsHeaders (10 tests)
TestEnsureValidOAuth2Context (13 tests)
Related issue(s)
NA