Repository navigation
Add failing tests for content path traversal - #11
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Content ids and endpoint names are joined into the request path without being confined to one segment, so parent-directory values are resolved onto other APIs. These tests expect that input to be rejected before any request is sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These tests pin down a path traversal in the content client.
get,list,create,update, anddeletejoin the endpoint name and the content id into the request path as raw text. Guzzle then resolves parent-directory segments againsthttps://{service}.microcms.io/api/v1/, so an id such as../inquiriesis sent as a request for a different content API, still carrying theX-MICROCMS-API-KEYheader.The tests fail on purpose until that input is rejected. A fix should throw
InvalidArgumentExceptionbefore the HTTP handler runs for any endpoint name or content id that is not a single safe path segment. No production code is changed here.testOrdinaryContentIdIsStillRequestedpasses today and should keep passing.How to run
On the current code this exits non-zero: 44 tests fail because a request is sent to the resolved URL of another API.
vendor/bin/phpunit tests/ClientTest.phpstill passes.