Repository navigation
store: address review findings in SetView, VersionedStorage, createNode, FrozenNodeSet - #6059
Merged
William Wong (compulim) merged 4 commits intoNov 19, 2026
Conversation
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
…hods, VersionedStorage ordering and snapshot-safe iteration Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
William Wong (compulim)
marked this pull request as ready for review
November 19, 2026 20:11
William Wong (compulim)
requested review from
Eugene (OEvgeny),
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 19, 2026 20:11
William Wong (compulim)
merged commit Nov 19, 2026
d929d9d
into
feat-new-store
41 of 44 checks passed
William Wong (compulim)
deleted the
copilot/add-test-cases-for-failing-scenarios
branch
November 19, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the outstanding review comments on
packages/store. Each comment first got a failing test, then the code fix.createNodeisSameIds, i.e. by ID.SetView(base ofFrozenSetandFrozenNodeSet)difference,intersection,isDisjointFrom,isSubsetOf,isSupersetOf,symmetricDifferenceandunionare hand-written using onlysize/has()/keys(). They no longer depend on nativeSet.prototypemethods, which are missing in Chrome/Firefox 100 and Safari 15.has(), soFrozenNodeSetmatches node references by@id.core-js-pureis not used:Setclass, soinstanceof Setisfalse.Set, which dropsFrozenNodeSet's ID matching, sounion()duplicates references.VersionedStorage: copy on moveMapshared with older versions is never reordered.DELETEDtombstone.Map.has(), and caches the result.Mapdirectly.ordered: falseoption;FrozenSkipListnow uses the default storage.Tests
SetView,createNode,FrozenNodeSet,VersionedStorage,FrozenMapandFrozenSet.FrozenMapexpectation is corrected to insertion order (['a', 'b', 'c']).