Repository navigation
Store: failing tests for unresolved #6053 review threads - #6061
Merged
William Wong (compulim) merged 2 commits intoNov 20, 2026
Merged
Conversation
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
… commit Co-authored-by: copilot-swe-agent[bot] <[email protected]>
William Wong (compulim)
marked this pull request as ready for review
November 20, 2026 02:03
William Wong (compulim)
requested review from
Eugene (OEvgeny),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 20, 2026 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
None. This PR only adds tests (label
no-changelog).Description
This PR adds failing tests for the two review threads on #6053 that are still unresolved. It doesn't fix either issue. The branch is based on
feat-new-store, so this PR should target that branch.Specific Changes
FrozenNodeSet.ts:17: a string and a node reference with the same ID are treated as the same value (FrozenNodeSet.test.ts)getEqualityKey()maps both'_:b'and{ '@id': '_:b' }to'_:b'.union()andsymmetricDifference()keep whichever comes first and drop the other.VersionedStorage.ts:491: an overlay iterator loses its place aftercommit()(VersionedStorage.test.ts)Mapdoing the same steps:[a, b, c]: reada, then…delete('a'),commit()b, ccdelete('a'),set('a', 100),commit()b, c, aI have added tests and executed them locally
I have added.changelog/<PR#>-<slug>.mdI have updated documentation