Skip to content

MAINT: Clear pyrit.score.scorer_evaluation.scorer_metrics_io from the keyword-only baseline - #4300

Merged
Roman Lutz (romanlutz) merged 5 commits into
microsoft:mainfrom
seragAhmed:maint/keyword-only-scorer-metrics-io
Nov 19, 2026
Merged

Roman Lutz (romanlutz) merged 5 commits into
microsoft:mainfrom
seragAhmed:maint/keyword-only-scorer-metrics-io

Conversation

@seragAhmed

@seragAhmed SERAG AHMED (seragAhmed) commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Relates to #4216. This clears pyrit.score.scorer_evaluation.scorer_metrics_io from the keyword-only baseline (3 entries), the module assigned to me in this comment.

All three are module-private helpers. Their only callers are in this module and in tests/unit/score/test_scorer_metrics_io.py, and none is passed as a callback, so no exemption marker is needed:

  • _append_jsonl_entry(file_path, *, lock, entry): its one caller already passed every argument by name.
  • _create_staging_file(file_path, *, mode=0o666): its one caller already passed mode=.
  • _rewrite_jsonl_atomically(file_path, *, lines): the caller in replace_evaluation_results now passes lines=output_lines.

file_path stays the single positional parameter, as the style guide allows. The three lines are removed from build_scripts/keyword_only_baseline.txt. There are no behaviour or public API changes.

Tests and Documentation

  • uv run python -m build_scripts.check_keyword_only_params passes. It fails while a removed baseline entry still violates the rule, so all 3 are covered.
  • tests/unit/score/test_scorer_metrics_io.py: 60 passed, 4 skipped (Windows). That includes the new test_jsonl_write_helpers_reject_positional_options, which checks that each helper refuses a positional option and writes nothing; its 3 cases fail against the old signatures.
  • tests/unit/build_scripts/test_check_keyword_only_params.py: 56 passed.
  • ruff check and ruff format --check are clean on both files.

AI assistance: I used Claude Code (Claude Opus 5.5) to help with this change; I reviewed it and ran the checks above myself.

_append_jsonl_entry, _create_staging_file and _rewrite_jsonl_atomically
are module-private helpers with callers only in this module and its tests.
Their options are now keyword-only (file_path stays the one positional
parameter), the caller in replace_evaluation_results passes lines=, and
the three baseline entries are removed. A test checks that positional
options are rejected.

Relates to microsoft#4216

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 05:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the keyword-only migration of the private scorer-metrics helpers.

No open issues 🎉

What changed in this PR

Advances #4216 by migrating three private scorer-metrics write helpers to keyword-only options, while keeping file_path positional and leaving public APIs unchanged.

Changes:

  • Makes lock, entry, mode, and lines keyword-only in the relevant helpers.
  • Updates callers and test doubles, and adds tests verifying positional options are rejected without creating files.
  • Removes the three migrated helpers from the keyword-only baseline.
File Description
tests/​unit/​score/​test_scorer_metrics_io.py Updates helper calls and adds positional-argument rejection tests.
pyrit/​score/​scorer_evaluation/​scorer_metrics_io.py Enforces keyword-only options and updates the registry replacement call.
build_scripts/​keyword_only_baseline.txt Removes the three migrated helper entries.

Review effort: Balanced

…nly test

test_jsonl_write_helpers_reject_positional_options calls the helpers positionally on purpose to check they raise TypeError, so ty's too-many-positional-arguments is expected there. Ignore it on those three lines, as other tests do.
The keyword-only checker fails CI if any of these signatures loses its
star, and ty flags positional calls, so the runtime TypeError test only
re-verified language semantics.

Co-Authored-By: Claude Fable 5 <[email protected]>
@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@seragAhmed

SERAG AHMED (seragAhmed) commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Roman Lutz (@romanlutz) The PR was automatically removed from the merge queue due to a transient Playwright browser download timeout on Ubuntu (fonts-wqy-zenhei 403/timeout) in the merge queue run. All PR checks remain green; could you please re-add it to the merge queue when you get a chance?

@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Nov 19, 2026
Merged via the queue into microsoft:main with commit 754eb44 Nov 19, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants