Skip to content

MAINT: Make insert punctuation helpers keyword-only - #4323

Merged
Roman Lutz (romanlutz) merged 2 commits into
microsoft:mainfrom
clossal:fix/4216-insert-punctuation-keyword-only
Nov 19, 2026
Merged

Roman Lutz (romanlutz) merged 2 commits into
microsoft:mainfrom
clossal:fix/4216-insert-punctuation-keyword-only

Conversation

@clossal

Copy link
Copy Markdown
Contributor

Description

Update the three private insertion helpers in InsertPunctuationConverter to use keyword-only parameters after their first data argument.

  • Update the three internal call sites to pass the affected parameters by name.
  • Remove the corresponding three entries from the keyword-only baseline.
  • Preserve the existing punctuation insertion behavior.

Relates to #4216

Copilot AI balanced review requested due to automatic review settings November 15, 2026 18:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the private-helper keyword-only migration.

No open issues 🎉

What changed in this PR

This PR advances #4216’s keyword-only migration by updating private helpers in InsertPunctuationConverter without changing punctuation insertion logic.

Changes:

  • Make parameters after the first data argument keyword-only in three private helpers.
  • Update all three internal call sites to pass those parameters by name.
  • Remove the three corresponding keyword-only baseline entries.
File Description
pyrit/​converter/​insert_punctuation_converter.py Updates helper signatures and internal calls to use keyword-only parameters.
build_scripts/​keyword_only_baseline.txt Removes the three migrated helper entries.

Review effort: Balanced

@clossal

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Nov 19, 2026
Merged via the queue into microsoft:main with commit 2d5a576 Nov 19, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants