Repository navigation
MAINT: Make insert punctuation helpers keyword-only - #4323
Merged
Roman Lutz (romanlutz) merged 2 commits intoNov 19, 2026
Merged
Roman Lutz (romanlutz) merged 2 commits into
Roman Lutz (romanlutz) merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the private-helper keyword-only migration.
No open issues 🎉
What changed in this PR
This PR advances #4216’s keyword-only migration by updating private helpers in InsertPunctuationConverter without changing punctuation insertion logic.
Changes:
- Make parameters after the first data argument keyword-only in three private helpers.
- Update all three internal call sites to pass those parameters by name.
- Remove the three corresponding keyword-only baseline entries.
| File | Description |
|---|---|
pyrit/converter/insert_punctuation_converter.py |
Updates helper signatures and internal calls to use keyword-only parameters. |
build_scripts/keyword_only_baseline.txt |
Removes the three migrated helper entries. |
Review effort: Balanced
Contributor
Author
|
@microsoft-github-policy-service agree |
Roman Lutz (romanlutz)
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the three private insertion helpers in
InsertPunctuationConverterto use keyword-only parameters after their first data argument.Relates to #4216