Repository navigation
Offer compiler version fallbacks on startup errors - #3704
Open
Jake Bailey (jakebailey) wants to merge 3 commits into
Open
Jake Bailey (jakebailey) wants to merge 3 commits into
Jake Bailey (jakebailey) wants to merge 3 commits into
Conversation
Match the v1 recovery path for links to removed TypeScript versions so users aren't left on a loading error with no way to continue. Keep fallback actions for version-specific unavailability and retain Retry for transient network failures.
"Use latest" previously reloaded the native default channel, which falls back to Nightly whenever the npm latest release has no WASM build. Users then had no way to reach a stable compiler, and the two recovery choices collapsed into the same Nightly load. Resolve "Use latest" to the npm latest release when the Playground supports it, otherwise to the newest supported stable release below it, so stale links land on a usable stable compiler. Offer both recovery choices for any compiler startup failure, since the failure causes are too varied to classify reliably, and hide a choice only when it names the version that just failed to load.
A failed "Use latest" lookup wrote its error straight into the loader, where the next status update erased it, leaving users without an explanation. A transient metadata failure while checking for the already-failed version also hid "Use latest" for the rest of the session, removing a recovery path that might succeed on another try. Keep the lookup error in state so every status render shows it, and hide a recovery action only when it is known to name the version that just failed.
Contributor
|
Azure Static Web Apps: Your preview site is ready! Visit it here: https://victorious-plant-05c166c10-3704.centralus.5.azurestaticapps.net |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the v1 recovery path for links to removed TypeScript versions so users aren't left on a loading error with no way to continue. Keep fallback actions for version-specific unavailability and retain Retry for transient network failures.