Repository navigation
[rush] Fix declared environment snapshot hashing - #6203
Open
Yashwanth Reddy Verupaka (yashwanth195) wants to merge 1 commit into
Open
Yashwanth Reddy Verupaka (yashwanth195) wants to merge 1 commit into
Yashwanth Reddy Verupaka (yashwanth195) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Rush cache identity for declared environment inputs: capture supplied values at snapshot creation, distinguish unset from empty, and resolve Windows environment names case-insensitively.
Details
EnvironmentMapfor snapshot capture, explicit per-operation environments, and previous-snapshot comparison. Preserve memoization, undeclared-input exclusion, and non-Windows case sensitivity.How it was tested
Windows, Node 24.22.1, Rush 5.182.0:
node common\scripts\install-run-rush.js build --to @microsoft/rush-lib --parallelism 4libraries\rush-lib:node ..\..\common\scripts\install-run-rushx.js _phase:test --test-path-pattern InputsSnapshot --max-workers 1 --disable-code-coveragenode common\scripts\install-run-rush.js prettiernode common\scripts\install-run-rush.js change --verify --target-branch upstream/main --no-fetchgit diff --cached --checkCoverage includes absent/empty/sentinel values, captured caller mutations, separator collisions, Windows and Linux name semantics, explicit operation environments before/after memoization, and previous-snapshot reuse. Jest reported fixture package-name collision warnings; the suite passed.
Build/tests preceded the final rebase onto
c2acd010079c6c08e63ba25d0b136ed2c1b16ccd. Upstream changed only unrelated Heft plugin selection; all four validated files were verified byte-identical after rebasing. No broad sharding or coverage matrix was run.Impacted documentation
None. The patch changefile documents the intentional cache-key change.