Skip to content

✨ add get by URL methods - #277

Merged
ianardee merged 2 commits into
mainfrom
add-by-url
Nov 4, 2026
Merged

ianardee merged 2 commits into
mainfrom
add-by-url

Conversation

@ianardee

@ianardee ianardee commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The client now treats result URLs as IDs, constructing invalid endpoints that break successful asynchronous parsing and existing direct-URL callers.

1 open issue
What changed in this PR

Adds explicit URL-based job and result retrieval methods to the V2 client, alongside the existing ID-based methods.

Changes:

  • Adds get_job_by_url and get_result_by_url client methods.
  • Refactors HTTP retrieval helpers and adds HTTPS URL validation.
  • Updates RBS signatures to match the new methods.
File Description
spec/​v2/​client_v2_spec.rb Adds a blank line; no test behavior changes.
sig/​mindee/​v2/​http/​mindee_api_v2.rbs Updates retrieval helper and validation signatures.
sig/​mindee/​v2/​client.rbs Declares the new URL-based client methods.
lib/​mindee/​v2/​http/​mindee_api_v2.rb Separates ID and URL retrieval and validates HTTPS URLs.
lib/​mindee/​v2/​client.rb Exposes URL-based methods and changes existing retrieval delegation.

Review effort: Balanced

Comment thread lib/mindee/v2/client.rb Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing HTTPS URL calls to get_result now hit malformed endpoints, while stale polling stubs cause cancellation and timeout tests to enter the real HTTP path.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread lib/mindee/v2/client.rb Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change breaks existing callers by treating supported HTTPS result URLs as inference IDs in get_result, producing requests to incorrect endpoints.

3 open issues
1 resolved since last review

Review effort: Balanced

Comment thread lib/mindee/v2/client.rb Resolved
Comment thread lib/mindee/v2/client.rb Resolved
Comment thread lib/mindee/v2/http/mindee_api_v2.rb Resolved
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
@ianardee
ianardee merged commit 3bb65fc into main Nov 4, 2026
35 checks passed
@ianardee
ianardee deleted the add-by-url branch November 4, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants