Repository navigation
✨ add get by URL methods - #277
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The client now treats result URLs as IDs, constructing invalid endpoints that break successful asynchronous parsing and existing direct-URL callers.
1 open issue
What changed in this PR
Adds explicit URL-based job and result retrieval methods to the V2 client, alongside the existing ID-based methods.
Changes:
- Adds
get_job_by_urlandget_result_by_urlclient methods. - Refactors HTTP retrieval helpers and adds HTTPS URL validation.
- Updates RBS signatures to match the new methods.
| File | Description |
|---|---|
spec/v2/client_v2_spec.rb |
Adds a blank line; no test behavior changes. |
sig/mindee/v2/http/mindee_api_v2.rbs |
Updates retrieval helper and validation signatures. |
sig/mindee/v2/client.rbs |
Declares the new URL-based client methods. |
lib/mindee/v2/http/mindee_api_v2.rb |
Separates ID and URL retrieval and validates HTTPS URLs. |
lib/mindee/v2/client.rb |
Exposes URL-based methods and changes existing retrieval delegation. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Types of changes