Repository navigation
Conversation
…or AS closes modelcontextprotocol#580 Signed-off-by: Takashi Norimatsu <[email protected]>
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #580
Motivation and Context
Described in #580
How Has This Been Tested?
npm test(Test Files 48 passed, Tests 646 passed)npm start -- list --authorization --spec-version 2026-07-28andnpm start -- list --authorization --spec-version 2025-11-25(same two scenario: authorization-server-metadata-endpoint, authorization-code-grant)Test against real AS (keycloak) - MCP 2026-07-28
npm start -- authorization --url http://localhost:8080/realms/mcp \ --client-id mcp-conformance --resource http://localhost:3001/mcp \ --port 3000 --spec-version 2026-07-28 -o /tmp/kc-resultsWe can customize keycloak easiliy, so I ran MCP 2026-07-28 conformance test against keycloak per the following four pattern. The brief result is as follows:
issin responseinclude-issadvertise-iss-supportedtruetruefalseThe results match the specification's expectations.
RFC 9207 supported (server metadata:
authorization_response_iss_parameter_supportedistrue, iss parameter included in an authorization response)With
cimdandresource-indicatorsenabled, Keycloak 26.8.2 now passes all 5 checks for 2026-07-28, with no failures or warnings.authorization-server-metadata-endpointauthorization-server-metadataauthorization-server-metadata-cimdauthorization-code-grantauthorization-code-grant(PKCE S256,resourcesent)sep-2468-as-include-isssep-2468-as-advertise-iss-supportedRFC 9207 not supported (server metadata:
authorization_response_iss_parameter_supportedisfalse,issparameter NOT included in in an authorization response)authorization-server-metadata-endpointauthorization-server-metadataauthorization-server-metadata-cimdauthorization-code-grantauthorization-code-grantsep-2468-as-include-iss(SHOULD)isssep-2468-as-advertise-iss-supportedissis sent (the check recordedauthorization_response_iss_parameter_supported: false)RFC 9207 partially supported (server metadata: no
authorization_response_iss_parameter_supported,issparameter included in an authorization response)This run fails one required (MUST) check, as expected: Keycloak sends
issin the authorization response, but its metadata no longer declaresauthorization_response_iss_parameter_supported. The CLI summary wasTotal: 4 passed, 1 failed.authorization-server-metadata-endpointauthorization-server-metadataauthorization-server-metadata-cimdauthorization-code-grantauthorization-code-grantsep-2468-as-include-ississ=http://localhost:8080/realms/mcp)sep-2468-as-advertise-iss-supported(MUST)authorization_response_iss_parameter_supported"Test against real AS (keycloak) - MCP 2025-11-25
npm start -- authorization --url http://localhost:8080/realms/mcp \ --client-id mcp-conformance --resource http://localhost:3001/mcp \ --port 3000 --spec-version 2025-11-25 -o /tmp/kc-resultsWe can customize keycloak easiliy, so I ran MCP 2025-11-25 conformance test against keycloak per the following four pattern. The brief result is as follows:
issin responseauthorization-server-metadataauthorization-server-metadata-cimdauthorization-code-granttruetruefalseThe results match the specification's expectations. The results are identical because the
isschecks (sep-2468-as-include-issandsep-2468-as-advertise-iss-supported) come from SEP-2468 and only apply from 2026-07-28. The 2025-11-25 run leaves them out, so how Keycloak handlesissmakes no difference here.RFC 9207 supported (server metadata:
authorization_response_iss_parameter_supportedistrue,issparameter included in an authorization response)authorization-server-metadata-endpointauthorization-server-metadataauthorization-server-metadata-cimdauthorization-code-grantauthorization-code-grant(PKCE S256,resourcesent)There are 2 fewer checks than in the 2026-07-28 run because the SEP-2468
isschecks (sep-2468-as-include-iss,sep-2468-as-advertise-iss-supported) are new in 2026-07-28, so the 2025-11-25 run leaves them out. Keycloak still sentissin the authorization response.Breaking Changes
Nothing
Types of changes
Checklist
Additional context