Repository navigation
[Conformance] Take the expected issuer of pre-registration from the runner - #716
Merged
chr-hertel merged 1 commit intoNov 9, 2026
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
November 9, 2026 23:47
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the update that pins pre-registration to the runner-provided issuer.
No open issues 🎉
What changed in this PR
Updates the conformance client to pin the pre-registration issuer supplied by the runner, rather than trusting issuer discovery from the server under test.
Changes:
- Reads pre-registered credentials and the expected issuer together from the runner context.
- Removes the issuer-discovery helper, unused imports, and URL parameter from authenticator setup.
| File | Description |
|---|---|
tests/Conformance/client.php |
Uses the runner-provided issuer for pre-registration and simplifies OAuth setup. |
Review effort: Balanced
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #666: the runner passes the issuer next to the pre-registered credentials, so the client pins it like an application would, instead of asking the server under test for it.