Repository navigation
[Server] Fix a flaky timing test and show why a concurrent session writer fails - #717
Merged
chr-hertel merged 2 commits intoNov 9, 2026
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
November 9, 2026 23:48
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the StatelessResponder test’s timing-tolerance adjustment.
No open issues 🎉
What changed in this PR
Reduces timing-related flakiness in the server’s StatelessResponder unit test while preserving the check that an idle turn waits.
Changes:
- Lowers the minimum elapsed-time assertion from 250 ms to 200 ms.
- Adds a comment explaining that Windows can end the sleep slightly early.
| File | Description |
|---|---|
tests/Unit/Server/Transport/Http/StatelessResponderTest.php |
Relaxes the timing threshold and documents the Windows tolerance. |
Review effort: Balanced
chr-hertel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idle turn of
StatelessRespondersleeps 250 ms, and the Windows job measured 0.2496 s on #713. The test only needs to show that the turn waits, so it now accepts 0.2 s.FileSessionStoreTest::testConcurrentWritesNeverPublishAPartialPayloadkeeps failing on Windows because a writer'swrite()returnsfalse, without saying why. The writers now log the store's warning to their error file, and the failure message includes it - the fix follows once CI shows the cause.