You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Docs] Condense and group the 0.10.0 changelog - #728
Adds a TL;DR, moves the namespace split and cross-cutting changes above the components, groups Server and Client entries by theme and merges the duplicated ones, like the 0.9.0 changelog. JSON-RPC folds into Schema, where MessageFactory lives now.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The changelog incorrectly attributes rejection of all 3xx responses to all three classes, although AuthenticatingHttpClient returns redirects unchanged and the error guarantee applies only to HttpTransport.
Reorganizes the SDK’s 0.10.0 changelog to make release highlights and migration details easier to scan, following the 0.9.0 layout. No runtime code changes.
Changes:
Adds a TL;DR and places namespace and cross-cutting changes before component details.
Groups Server and Client entries by theme and merges duplicate entries.
Moves JSON-RPC entries into Schema, where MessageFactory resides.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The changelog incorrectly implies handlers run under an event loop by default, when this behavior is opt-in via Builder::setFiberScheduler().
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Clarify event-loop support requires setFiberScheduler()
CHANGELOG.md:14
Event-loop execution is opt-in (Builder::$fiberScheduler defaults to null), so this reads as a new default execution model that the SDK does not actually introduce. Please describe support for running handlers under an event loop with Builder::setFiberScheduler(), rather than stating that handlers run under one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentationImprovements or additions to documentation
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a TL;DR, moves the namespace split and cross-cutting changes above the components, groups Server and Client entries by theme and merges the duplicated ones, like the 0.9.0 changelog. JSON-RPC folds into Schema, where
MessageFactorylives now.