Skip to content

fix(resources): honor warn_on_duplicate_resources in add_template - #3823

Closed
davrens101 wants to merge 1 commit into
modelcontextprotocol:mainfrom
davrens101:fix/add-template-duplicate-warning
Closed

davrens101 wants to merge 1 commit into
modelcontextprotocol:mainfrom
davrens101:fix/add-template-duplicate-warning

Conversation

@davrens101

@davrens101 davrens101 commented Nov 6, 2026 •

Copy link
Copy Markdown

Fixes #3813

ResourceManager.add_template() ignored warn_on_duplicate_resources and silently overwrote an existing template registered for the same URI template. Mirror add_resource(): when a template with the same URI template already exists, log a warning (when enabled) and return the existing template instead of overwriting it.

AI assistance: drafted with AI tooling, reviewed by the author.

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3813.

If a maintainer assigns you to #3813, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ResourceManager.add_template() ignores warn_on_duplicate_resources and silently overwrites existing templates

1 participant