Repository navigation
fix(mcpserver): honor warn_on_duplicate_resources in ResourceManager.add_template (#3813) - #3827
thinhnx128 wants to merge 1 commit into
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3813. If a maintainer assigns you to #3813, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
Fixes #3813
Problem
ResourceManager.add_resource()checksself._resources.get(str(resource.uri)), logs a warning whenself.warn_on_duplicate_resourcesis enabled, and returns the existing resource without overwriting it. However,ResourceManager.add_template()ignoredself.warn_on_duplicate_resourcesand silently overwrote existing templates inself._templates[template.uri_template].Solution
Check
existing = self._templates.get(template.uri_template)inResourceManager.add_template(), emitlogger.warning(f"Template already exists: {template.uri_template}")whenself.warn_on_duplicate_resourcesisTrue, and returnexistingconsistently withadd_resource().