Skip to content

fix(shared): catch ValueError for non-ASCII base64 in decode_header_value (#3817) #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thinhnx128 wants to merge 1 commit into from
Closed

fix(shared): catch ValueError for non-ASCII base64 in decode_header_value (#3817) #3828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/mcp/shared/inbound.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"""

import base64
import binascii
import re
from collections.abc import Iterable, Iterator, Mapping, Sequence
from dataclasses import dataclass
Expand Down Expand Up @@ -176,7 +175,7 @@ def decode_header_value(value: str | None) -> str | None:
payload = m.group("payload")
try:
decoded = base64.b64decode(payload, validate=True)
except binascii.Error:
except ValueError:
return None
# Reject non-canonical base64 (e.g. non-zero trailing bits), which
# `validate=True` tolerates; the encoder only ever emits canonical form.
Expand Down
Loading