Skip to content

refactor(storybook-framework-web-components): set core.builder to the builder entry file - #3244

Open
web-padawan wants to merge 1 commit into
masterfrom
refactor/storybook-framework-builder-entry
Open

web-padawan wants to merge 1 commit into
masterfrom
refactor/storybook-framework-builder-entry

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What I did

  1. Set core.builder in the framework preset to the resolved entry file of @web/storybook-builder instead of its package directory.

The Storybook 10 migration guide asks for the entry file of the builder:

When setting the core.builder or core.builder.name option in the main configuration, it must now be a fully resolved path to a builder's entry point, instead of just to the builder package's root directory.

Storybook 10 first calls import() on the value, which fails for a directory. It then uses require() as a fallback.
Storybook 9 calls require.resolve on the value before import(), so both forms load the same file.

Part of #2989.

@changeset-bot

changeset-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6c902b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/storybook-framework-web-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@web-padawan
web-padawan requested a review from bashmish November 18, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant