Skip to content

fix: all rows highlighted in install to play content modal - #8321

Merged
mergify[bot] merged 1 commit into
modrinth:mainfrom
creeperkatze:fix-modpack-content-borders
Nov 18, 2026
Merged

mergify[bot] merged 1 commit into
modrinth:mainfrom
creeperkatze:fix-modpack-content-borders

Conversation

@creeperkatze

Copy link
Copy Markdown
Contributor

Fixes every row in the install to play modal's content list having a green outline, when clicking view after pressing play on a server.

The modal built its content items without an id, so ContentCardTable matched every row against the unset highlightedItemId and outlined all of them. Items now use the project ID, falling back to the file name.

@creeperkatze

Copy link
Copy Markdown
Contributor Author
image

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

@Prospector

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Merged into main as f5dd000 at 19:17 UTC

1 min in the queue, with no time running CI.

So far

2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-skipped = Lint and Test
    • check-neutral = Lint and Test
    • check-success = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 18, 2026
@mergify
mergify Bot merged commit f5dd000 into modrinth:main Nov 18, 2026
16 checks passed
@mergify mergify Bot removed the queued label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants