Repository navigation
add game awards card - #8358
add game awards card#8358
Conversation
|
Note This changelog has been baked. Any further edits will not be reflected. Pull request changelogAppAdded
ChangedDeprecatedRemovedFixedSecurityWebsiteAdded
ChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
This pull request is merged. |
[Medium impact] The new card affects one project’s pages on the website and desktop app. Satisfy the required story and surface-color rules before merging; the deadline and countdown issues also need attention.
|
| return { | ||
| projectName: project.title, | ||
| year: 2026, | ||
| votingDeadline: new Date(2026, 11, 10), |
There was a problem hiding this comment.
new Date(2026, 11, 10) sets the deadline to each viewer’s local midnight rather than one shared instant. Visitors in different time zones lose the voting details at different times. If the server and browser use different time zones, their countdowns can also differ. Use an explicit timestamp with the event’s time zone.
Knowledge Base Used: Web marketplace application
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/ui/src/components/project/game-awards.ts
Line: 17
Comment:
**Deadline changes by time zone**
`new Date(2026, 11, 10)` sets the deadline to each viewer’s local midnight rather than one shared instant. Visitors in different time zones lose the voting details at different times. If the server and browser use different time zones, their countdowns can also differ. Use an explicit timestamp with the event’s time zone.
**Knowledge Base Used:** [Web marketplace application](https://app.greptile.com/-/switch-tenant?tenant=modrinth&next=%2Fcustom-context%2Fknowledge-base%2Fmodrinth%2Fcode%2F-%2Fdocs%2Fweb-marketplace.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Frontend previewsLast deployed commit is 0737306f6bf705fe5166fb6dd5e8dfbe6eae9dff Persistent
Latest commit
|
No description provided.