Skip to content

fix: keep vite-plus dependency updates grouped - #992

Merged
fengmk2 merged 1 commit into
masterfrom
codex/renovate-vite-plus-group
Nov 17, 2026
Merged

fengmk2 merged 1 commit into
masterfrom
codex/renovate-vite-plus-group

Conversation

@fengmk2

@fengmk2 fengmk2 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Renovate separates major and minor updates even when packages share a group. This split the vite-plus update in #989 from the @voidzero-dev/vite-plus-core update in #990.

Set separateMajorMinor to false for the existing vite-plus group so these dependencies update in one PR.

Summary by CodeRabbit

  • Chores
    • Adjusted update handling for select packages so major and minor version updates are grouped together. This changes how those updates are presented for review; it does not describe a change to app functionality.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 14:39
@agentscanapp

agentscanapp Bot commented Nov 17, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Renovate configuration sets separateMajorMinor to false for packages matched by the vite-plus rule.

Changes: Vite Plus Renovate grouping

Layer / File(s) Summary
Package update grouping
renovate.json
The vite-plus package rule sets separateMajorMinor to false.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related issues

  • Issue 498 describes separate Renovate entries for vite-plus and vite updates. This change sets separateMajorMinor to false for the vite-plus rule, which corresponds to the grouping objective.
Merge Risk: Minimal · up to ea4e7

This changes Renovate grouping so that vite-plus dependency updates arrive together in one PR. It affects only dependency update PR creation, and no production impact or merge risk is apparent.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix: keep vite-plus dependency updates grouped" matches the only change in the changeset. The renovate.json change sets separateMajorMinor to false for the vite-plus package rule, which kee…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix: keep vite-plus dependency updates grouped" matches the only change in the changeset. The renovate.json change sets separateMajorMinor to false for the vite-plus package rule, which keeps those updates in one group as the PR objectives describe. The title names the main change and the intent, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9b6adb2e-a5f9-4941-8793-68d637aa8d0c
Commits

Reviewing files that changed from the base of the PR and between 75e2552 and ea4e70d.

Files selected for processing: 1

  • renovate.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@992

commit: ea4e70d

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for this Renovate configuration change.

No open issues 🎉

What changed in this PR

Updates Renovate configuration to keep related Vite+ dependencies in one PR, addressing the major/minor split seen in #989 and #990.

Changes:

  • Sets separateMajorMinor to false for the existing vite-plus group without changing package matching or release-age settings.
File Description
renovate.json Allows major and minor updates within the Vite+ group to be combined.

Review effort: Balanced

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.91%. Comparing base (75e2552) to head (ea4e70d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #992   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          10       10           
  Lines         747      747           
  Branches      235      235           
=======================================
  Hits          709      709           
  Misses         35       35           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2
fengmk2 merged commit 424c200 into master Nov 17, 2026
19 of 21 checks passed
@fengmk2
fengmk2 deleted the codex/renovate-vite-plus-group branch November 17, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants