Repository navigation
jenkins: update download-test.sh script - #4572
Open
richardlau wants to merge 1 commit into
Open
richardlau wants to merge 1 commit into
richardlau wants to merge 1 commit into
Conversation
- No longer rsync to unencrypted, which has not been kept updated for some time so the script was finding old builds as the "most recent" ones for older release lines, and completely missing any releases for e.g. Node.js 26. - Use `index.tab` to find the most recent match instead of scraping the directory listing web page. - Use `expected_assets` and test all expected files for the release line the match belongs to (or the previous release line if it is a nightly from `main`) are present and validate their checksum to the entry in `SHASUMS256.txt`. Assisted-by: a closed-source coding agent Signed-off-by: Richard Lau <[email protected]>
richardlau
force-pushed
the
download-test
branch
from
November 19, 2026 19:06
210bf8e to
39b3d17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index.tabto find the most recent match instead of scraping the directory listing web page.expected_assetsand test all expected files for the release line the match belongs to (or the previous release line if it is a nightly frommain) are present and validate their checksum to the entry inSHASUMS256.txt.This script is used in https://ci.nodejs.org/job/validate-downloads/. Without these changes (e.g. with the script still rsyncing to unencrypted), the script finds
None of which are the intended most recent releases on those lines. I have avoided the rclone based mirroring script from #4525 as the
jenkins-workspacemachines that the validate-downloads job runs on does not havercloneinstalled.