Skip to content

jenkins: update download-test.sh script - #4572

Open
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:download-test
Open

richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:download-test

Conversation

@richardlau

Copy link
Copy Markdown
Member
  • No longer rsync to unencrypted, which has not been kept updated for some time so the script was finding old builds as the "most recent" ones for older release lines, and completely missing any releases for e.g. Node.js 26.
  • Use index.tab to find the most recent match instead of scraping the directory listing web page.
  • Use expected_assets and test all expected files for the release line the match belongs to (or the previous release line if it is a nightly from main) are present and validate their checksum to the entry in SHASUMS256.txt.

This script is used in https://ci.nodejs.org/job/validate-downloads/. Without these changes (e.g. with the script still rsyncing to unencrypted), the script finds

  • v22.16.0 for Node.js 22.x
  • v24.1.0 for Node.js 24.x
  • No releases for Node.js 26.x

None of which are the intended most recent releases on those lines. I have avoided the rclone based mirroring script from #4525 as the jenkins-workspace machines that the validate-downloads job runs on does not have rclone installed.

- No longer rsync to unencrypted, which has not been kept updated for
some time so the script was finding old builds as the "most recent"
ones for older release lines, and completely missing any releases for
e.g. Node.js 26.
- Use `index.tab` to find the most recent match instead of scraping the
directory listing web page.
- Use `expected_assets` and test all expected files for the release line
the match belongs to (or the previous release line if it is a nightly
from `main`) are present and validate their checksum to the entry in
`SHASUMS256.txt`.

Assisted-by: a closed-source coding agent
Signed-off-by: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant